Changeset bbcd06e in mainline

Timestamp:

2025-04-01T10:20:06Z (4 months ago)

Author:

Miroslav Cimerman <mc@…>

Children:

ca7fa5b

Parents:

52be5fa

Message:

hr: keep counter only in memory saved metadata

Location:

uspace/srv/bd/hr

Files:

• superblock.c (modified) (1 diff)
• util.c (modified) (3 diffs)
• var.h (modified) (2 diffs)

uspace/srv/bd/hr/superblock.c

@@ -60 +60 @@
 
         md->counter = 0;
-        vol->counter = md->counter;
 
         uuid_t uuid;

uspace/srv/bd/hr/util.c

@@ -792 +792 @@
         vol->truncated_blkno = main_md->truncated_blkno;
         vol->data_offset = main_md->data_offset;
-        vol->counter = main_md->counter;
         vol->metadata_version = main_md->version;
         vol->extent_no = main_md->extent_no;
@@ -824 +823 @@
 
         /*
-         * TODO: something like mark md dirty or whatever, just sync the
-         * vol->counter with vol->in_mem_md->counter, or merge them and only
-         * keep the vol->in_mem_md->counter...
+         * TODO: something like mark md dirty or whatever
+         *      - probably will be handled by each md type differently,
+         *        by specific function pointers
+         *      - deal with this when foreign md will be handled
          *
          * XXX: if thats the only thing that can change in metadata
@@ -836 +836 @@
          * write... but for now leave it here
          */
-        vol->counter++;
-        vol->in_mem_md->counter = vol->counter;
+        vol->in_mem_md->counter++;
 
         hr_metadata_save(vol);

uspace/srv/bd/hr/var.h

@@ -72 +72 @@
         hr_fpool_t      *fge;                   /* fibril pool */
 
-        uint32_t         metadata_version; /* XXX: yet unused */
+        /*
+         * TODO: also print in info, doesn't have
+         * to be part of hr_volume_t but just the info
+         * that is passed to be printed
+         *
+         * Probably just defer this decition until foreign md
+         * will be handled.
+         */
+        uint32_t         metadata_version;
 
-        hr_metadata_t   *in_mem_md; /* TODO: implement */
+        hr_metadata_t   *in_mem_md;
 
         /* invariants */
@@ -102 +110 @@
         _Atomic uint64_t rebuild_blk;           /* rebuild position */
         _Atomic int      open_cnt;              /* open/close() counter */
-        uint64_t         counter;               /* TODO: metadata syncing */
         hr_vol_status_t  status;                /* volume status */
 } hr_volume_t;