Changes in kernel/genarch/src/fb/fb.c [b366a6f4:ba7371f9] in mainline

File:

• kernel/genarch/src/fb/fb.c (modified) (15 diffs)

kernel/genarch/src/fb/fb.c

@@ -82 +82 @@
         SPINLOCK_DECLARE(lock);
         
-        parea_t parea;
-        
         uint8_t *addr;
         uint16_t *backbuf;
@@ -111 +109 @@
 } fb_instance_t;
 
-static void fb_putchar(outdev_t *dev, wchar_t ch);
+static void fb_putchar(outdev_t *dev, wchar_t ch, bool silent);
 static void fb_redraw_internal(fb_instance_t *instance);
 static void fb_redraw(outdev_t *dev);
@@ -217 +215 @@
  *
  */
-static void logo_hide(fb_instance_t *instance)
+static void logo_hide(fb_instance_t *instance, bool silent)
 {
         instance->ylogo = 0;
@@ -223 +221 @@
         instance->rowtrim = instance->rows;
         
-        if ((!instance->parea.mapped) || (console_override))
+        if (!silent)
                 fb_redraw_internal(instance);
 }
@@ -231 +229 @@
  */
 static void glyph_draw(fb_instance_t *instance, uint16_t glyph,
-    unsigned int col, unsigned int row, bool overlay)
+    unsigned int col, unsigned int row, bool silent, bool overlay)
 {
         unsigned int x = COL2X(col);
@@ -238 +236 @@
         
         if (y >= instance->ytrim)
-                logo_hide(instance);
+                logo_hide(instance, silent);
         
         if (!overlay)
                 instance->backbuf[BB_POS(instance, col, row)] = glyph;
         
-        if ((!instance->parea.mapped) || (console_override)) {
+        if (!silent) {
                 for (yd = 0; yd < FONT_SCANLINES; yd++)
                         memcpy(&instance->addr[FB_POS(instance, x, y + yd + instance->ylogo)],
@@ -255 +253 @@
  *
  */
-static void screen_scroll(fb_instance_t *instance)
+static void screen_scroll(fb_instance_t *instance, bool silent)
 {
         if (instance->ylogo > 0) {
-                logo_hide(instance);
+                logo_hide(instance, silent);
                 return;
         }
         
-        if ((!instance->parea.mapped) || (console_override)) {
+        if (!silent) {
                 unsigned int row;
                 
@@ -300 +298 @@
 }
 
-static void cursor_put(fb_instance_t *instance)
+static void cursor_put(fb_instance_t *instance, bool silent)
 {
         unsigned int col = instance->position % instance->cols;
         unsigned int row = instance->position / instance->cols;
         
-        glyph_draw(instance, fb_font_glyph(U_CURSOR), col, row, true);
-}
-
-static void cursor_remove(fb_instance_t *instance)
+        glyph_draw(instance, fb_font_glyph(U_CURSOR), col, row, silent, true);
+}
+
+static void cursor_remove(fb_instance_t *instance, bool silent)
 {
         unsigned int col = instance->position % instance->cols;
@@ -314 +312 @@
         
         glyph_draw(instance, instance->backbuf[BB_POS(instance, col, row)],
-            col, row, true);
+            col, row, silent, true);
 }
 
@@ -364 +362 @@
  *
  */
-static void fb_putchar(outdev_t *dev, wchar_t ch)
+static void fb_putchar(outdev_t *dev, wchar_t ch, bool silent)
 {
         fb_instance_t *instance = (fb_instance_t *) dev->data;
@@ -371 +369 @@
         switch (ch) {
         case '\n':
-                cursor_remove(instance);
+                cursor_remove(instance, silent);
                 instance->position += instance->cols;
                 instance->position -= instance->position % instance->cols;
                 break;
         case '\r':
-                cursor_remove(instance);
+                cursor_remove(instance, silent);
                 instance->position -= instance->position % instance->cols;
                 break;
         case '\b':
-                cursor_remove(instance);
+                cursor_remove(instance, silent);
                 if (instance->position % instance->cols)
                         instance->position--;
                 break;
         case '\t':
-                cursor_remove(instance);
+                cursor_remove(instance, silent);
                 do {
                         glyph_draw(instance, fb_font_glyph(' '),
                             instance->position % instance->cols,
-                            instance->position / instance->cols, false);
+                            instance->position / instance->cols, silent, false);
                         instance->position++;
                 } while ((instance->position % 8)
@@ -397 +395 @@
                 glyph_draw(instance, fb_font_glyph(ch),
                     instance->position % instance->cols,
-                    instance->position / instance->cols, false);
+                    instance->position / instance->cols, silent, false);
                 instance->position++;
         }
@@ -403 +401 @@
         if (instance->position >= instance->cols * instance->rows) {
                 instance->position -= instance->cols;
-                screen_scroll(instance);
-        }
-        
-        cursor_put(instance);
+                screen_scroll(instance, silent);
+        }
+        
+        cursor_put(instance, silent);
         
         spinlock_unlock(&instance->lock);
@@ -557 +555 @@
         
         spinlock_initialize(&instance->lock, "*fb.instance.lock");
-        
         instance->rgb_conv = rgb_conv;
         instance->pixelbytes = pixelbytes;
@@ -626 +623 @@
         glyphs_render(instance);
         
-        link_initialize(&instance->parea.link);
-        instance->parea.pbase = props->addr;
-        instance->parea.frames = SIZE2FRAMES(fbsize);
-        instance->parea.unpriv = false;
-        instance->parea.mapped = false;
-        ddi_parea_register(&instance->parea);
-        
         if (!fb_exported) {
                 /*
-                 * We export the kernel framebuffer for uspace usage.
-                 * This is used in the case the uspace framebuffer
-                 * driver is not self-sufficient.
+                 * This is the necessary evil until the userspace driver is entirely
+                 * self-sufficient.
                  */
                 sysinfo_set_item_val("fb", NULL, true);