Changeset b7fd2a0 in mainline for uspace/srv/net/dnsrsrv/query.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/net/dnsrsrv/query.c (modified) (4 diffs)

uspace/srv/net/dnsrsrv/query.c

@@ -47 +47 @@
 static uint16_t msg_id;
 
-static int dns_name_query(const char *name, dns_qtype_t qtype,
+static errno_t dns_name_query(const char *name, dns_qtype_t qtype,
     dns_host_info_t *info)
 {
@@ -92 +92 @@
         log_msg(LOG_DEFAULT, LVL_DEBUG, "dns_name_query: send DNS request");
         dns_message_t *amsg;
-        int rc = dns_request(msg, &amsg);
+        errno_t rc = dns_request(msg, &amsg);
         if (rc != EOK) {
                 dns_message_destroy(msg);
@@ -190 +190 @@
 }
 
-int dns_name2host(const char *name, dns_host_info_t **rinfo, ip_ver_t ver)
+errno_t dns_name2host(const char *name, dns_host_info_t **rinfo, ip_ver_t ver)
 {
         dns_host_info_t *info = calloc(1, sizeof(dns_host_info_t));
@@ -196 +196 @@
                 return ENOMEM;
         
-        int rc;
+        errno_t rc;
         
         switch (ver) {