Changeset b7fd2a0 in mainline for uspace/srv/logger/writer.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/logger/writer.c (modified) (4 diffs)

uspace/srv/logger/writer.c

@@ -53 +53 @@
 {
         void *name;
-        int rc = async_data_write_accept(&name, true, 1, 0, 0, NULL);
+        errno_t rc = async_data_write_accept(&name, true, 1, 0, 0, NULL);
         if (rc != EOK)
                 return NULL;
@@ -64 +64 @@
 }
 
-static int handle_receive_message(sysarg_t log_id, sysarg_t level)
+static errno_t handle_receive_message(sysarg_t log_id, sysarg_t level)
 {
         logger_log_t *log = find_log_by_id_and_lock(log_id);
@@ -71 +71 @@
 
         void *message = NULL;
-        int rc = async_data_write_accept(&message, true, 1, 0, 0, NULL);
+        errno_t rc = async_data_write_accept(&message, true, 1, 0, 0, NULL);
         if (rc != EOK)
                 goto leave;
@@ -128 +128 @@
                 }
                 case LOGGER_WRITER_MESSAGE: {
-                        int rc = handle_receive_message(IPC_GET_ARG1(call),
+                        errno_t rc = handle_receive_message(IPC_GET_ARG1(call),
                             IPC_GET_ARG2(call));
                         async_answer_0(callid, rc);