Changeset b7fd2a0 in mainline for uspace/srv/hid/input/ctl

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/srv/hid/input/ctl

Files:

• kbdev.c (modified) (4 diffs)
• stty.c (modified) (2 diffs)
• sun.c (modified) (2 diffs)

uspace/srv/hid/input/ctl/kbdev.c

@@ -51 +51 @@
 #include "../kbd_port.h"
 
-static int kbdev_ctl_init(kbd_dev_t *);
+static errno_t kbdev_ctl_init(kbd_dev_t *);
 static void kbdev_ctl_set_ind(kbd_dev_t *, unsigned int);
 
@@ -90 +90 @@
 }
 
-static int kbdev_ctl_init(kbd_dev_t *kdev)
+static errno_t kbdev_ctl_init(kbd_dev_t *kdev)
 {
         async_sess_t *sess = loc_service_connect(kdev->svc_id,
@@ -119 +119 @@
         
         port_id_t port;
-        int rc = async_create_callback_port(exch, INTERFACE_KBD_CB, 0, 0,
+        errno_t rc = async_create_callback_port(exch, INTERFACE_KBD_CB, 0, 0,
             kbdev_callback_conn, kbdev, &port);
         
@@ -150 +150 @@
 {
         kbdev_t *kbdev;
-        int retval;
+        errno_t retval;
         int type, key;
 

uspace/srv/hid/input/ctl/stty.c

@@ -46 +46 @@
 
 static void stty_ctl_parse(sysarg_t);
-static int stty_ctl_init(kbd_dev_t *);
+static errno_t stty_ctl_init(kbd_dev_t *);
 static void stty_ctl_set_ind(kbd_dev_t *, unsigned int);
 
@@ -237 +237 @@
 };
 
-static int stty_ctl_init(kbd_dev_t *kdev)
+static errno_t stty_ctl_init(kbd_dev_t *kdev)
 {
         kbd_dev = kdev;

uspace/srv/hid/input/ctl/sun.c

@@ -44 +44 @@
 
 static void sun_ctl_parse(sysarg_t);
-static int sun_ctl_init(kbd_dev_t *);
+static errno_t sun_ctl_init(kbd_dev_t *);
 static void sun_ctl_set_ind(kbd_dev_t *, unsigned int);
 
@@ -60 +60 @@
 static int scanmap_simple[];
 
-static int sun_ctl_init(kbd_dev_t *kdev)
+static errno_t sun_ctl_init(kbd_dev_t *kdev)
 {
         kbd_dev = kdev;