Changeset b7fd2a0 in mainline for uspace/lib/usbvirt/include

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/lib/usbvirt/include/usbvirt

Files:

• device.h (modified) (5 diffs)
• ipc.h (modified) (1 diff)
• virthub_base.h (modified) (2 diffs)

uspace/lib/usbvirt/include/usbvirt/device.h

@@ -56 +56 @@
  * @return Error code.
  */
-typedef int (*usbvirt_on_data_to_device_t)(usbvirt_device_t *dev,
+typedef errno_t (*usbvirt_on_data_to_device_t)(usbvirt_device_t *dev,
     usb_endpoint_t endpoint, usb_transfer_type_t transfer_type,
     const void *buffer, size_t buffer_size);
@@ -70 +70 @@
  * @return Error code.
  */
-typedef int (*usbvirt_on_data_from_device_t)(usbvirt_device_t *dev,
+typedef errno_t (*usbvirt_on_data_from_device_t)(usbvirt_device_t *dev,
     usb_endpoint_t endpoint, usb_transfer_type_t transfer_type,
     void *buffer, size_t buffer_size, size_t *act_buffer_size);
@@ -85 +85 @@
  * @return Error code.
  */
-typedef int (*usbvirt_on_control_t)(usbvirt_device_t *dev,
+typedef errno_t (*usbvirt_on_control_t)(usbvirt_device_t *dev,
     const usb_device_request_setup_packet_t *setup_packet,
     uint8_t *data, size_t *act_data_size);
@@ -239 +239 @@
 };
 
-extern int req_nop(usbvirt_device_t *device,
+extern errno_t req_nop(usbvirt_device_t *device,
     const usb_device_request_setup_packet_t *setup_packet,
     uint8_t *data, size_t *act_size);
 
-extern int usbvirt_device_plug(usbvirt_device_t *, const char *);
+extern errno_t usbvirt_device_plug(usbvirt_device_t *, const char *);
 extern void usbvirt_device_unplug(usbvirt_device_t *);
 
@@ -250 +250 @@
     const void *, size_t);
 
-extern int usbvirt_control_write(usbvirt_device_t *, const void *, size_t,
+extern errno_t usbvirt_control_write(usbvirt_device_t *, const void *, size_t,
     void *, size_t);
-extern int usbvirt_control_read(usbvirt_device_t *, const void *, size_t,
+extern errno_t usbvirt_control_read(usbvirt_device_t *, const void *, size_t,
     void *, size_t, size_t *);
-extern int usbvirt_data_out(usbvirt_device_t *, usb_transfer_type_t,
+extern errno_t usbvirt_data_out(usbvirt_device_t *, usb_transfer_type_t,
     usb_endpoint_t, const void *, size_t);
-extern int usbvirt_data_in(usbvirt_device_t *, usb_transfer_type_t,
+extern errno_t usbvirt_data_in(usbvirt_device_t *, usb_transfer_type_t,
     usb_endpoint_t, void *, size_t, size_t *);
 

uspace/lib/usbvirt/include/usbvirt/ipc.h

@@ -54 +54 @@
 } usbvirt_hc_to_device_method_t;
 
-extern int usbvirt_ipc_send_control_read(async_sess_t *, void *, size_t,
+extern errno_t usbvirt_ipc_send_control_read(async_sess_t *, void *, size_t,
     void *, size_t, size_t *);
-extern int usbvirt_ipc_send_control_write(async_sess_t *, void *, size_t,
+extern errno_t usbvirt_ipc_send_control_write(async_sess_t *, void *, size_t,
     void *, size_t);
-extern int usbvirt_ipc_send_data_in(async_sess_t *, usb_endpoint_t,
+extern errno_t usbvirt_ipc_send_data_in(async_sess_t *, usb_endpoint_t,
     usb_transfer_type_t, void *, size_t, size_t *);
-extern int usbvirt_ipc_send_data_out(async_sess_t *, usb_endpoint_t,
+extern errno_t usbvirt_ipc_send_data_out(async_sess_t *, usb_endpoint_t,
     usb_transfer_type_t, void *, size_t);
 

uspace/lib/usbvirt/include/usbvirt/virthub_base.h

@@ -56 +56 @@
 void *virthub_get_data(usbvirt_device_t *dev);
 
-int virthub_base_init(virthub_base_t *instance,
+errno_t virthub_base_init(virthub_base_t *instance,
     const char *name, usbvirt_device_ops_t *ops, void *data,
     const usb_standard_device_descriptor_t *device_desc,
@@ -63 +63 @@
 usb_address_t virthub_base_get_address(virthub_base_t *instance);
 
-int virthub_base_request(virthub_base_t *instance, usb_target_t target,
+errno_t virthub_base_request(virthub_base_t *instance, usb_target_t target,
     usb_direction_t dir, const usb_device_request_setup_packet_t *setup,
     void *buffer, size_t buffer_size, size_t *real_size);
 
-int virthub_base_get_hub_descriptor(usbvirt_device_t *dev,
+errno_t virthub_base_get_hub_descriptor(usbvirt_device_t *dev,
     const usb_device_request_setup_packet_t *request, uint8_t *data,
     size_t *act_size);
-int virthub_base_get_null_status(usbvirt_device_t *dev,
+errno_t virthub_base_get_null_status(usbvirt_device_t *dev,
     const usb_device_request_setup_packet_t *request, uint8_t *data,
     size_t *act_size);