Changeset b7fd2a0 in mainline for uspace/lib/usbhost/include/usb/host/usb_bus.h

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/usbhost/include/usb/host/usb_bus.h (modified) (3 diffs)

uspace/lib/usbhost/include/usb/host/usb_bus.h

@@ -58 +58 @@
 typedef size_t (*bw_count_func_t)(usb_speed_t, usb_transfer_type_t, size_t, size_t);
 typedef void (*ep_remove_callback_t)(endpoint_t *, void *);
-typedef int (*ep_add_callback_t)(endpoint_t *, void *);
+typedef errno_t (*ep_add_callback_t)(endpoint_t *, void *);
 
 /** Endpoint management structure */
@@ -85 +85 @@
     size_t size, size_t max_packet_size);
 
-int usb_bus_init(usb_bus_t *instance,
+errno_t usb_bus_init(usb_bus_t *instance,
     size_t available_bandwidth, bw_count_func_t bw_count, usb_speed_t max_speed);
 
-int usb_bus_register_ep(usb_bus_t *instance, endpoint_t *ep, size_t data_size);
+errno_t usb_bus_register_ep(usb_bus_t *instance, endpoint_t *ep, size_t data_size);
 
-int usb_bus_unregister_ep(usb_bus_t *instance, endpoint_t *ep);
+errno_t usb_bus_unregister_ep(usb_bus_t *instance, endpoint_t *ep);
 
 endpoint_t * usb_bus_find_ep(usb_bus_t *instance,
     usb_address_t address, usb_endpoint_t ep, usb_direction_t direction);
 
-int usb_bus_add_ep(usb_bus_t *instance,
+errno_t usb_bus_add_ep(usb_bus_t *instance,
     usb_address_t address, usb_endpoint_t endpoint, usb_direction_t direction,
     usb_transfer_type_t type, size_t max_packet_size, unsigned packets,
@@ -101 +101 @@
     usb_address_t tt_address, unsigned tt_port);
 
-int usb_bus_remove_ep(usb_bus_t *instance,
+errno_t usb_bus_remove_ep(usb_bus_t *instance,
     usb_address_t address, usb_endpoint_t endpoint, usb_direction_t direction,
     ep_remove_callback_t callback, void *arg);
 
-int usb_bus_reset_toggle(usb_bus_t *instance, usb_target_t target, bool all);
+errno_t usb_bus_reset_toggle(usb_bus_t *instance, usb_target_t target, bool all);
 
-int usb_bus_remove_address(usb_bus_t *instance,
+errno_t usb_bus_remove_address(usb_bus_t *instance,
     usb_address_t address, ep_remove_callback_t callback, void *arg);
 
-int usb_bus_request_address(usb_bus_t *instance,
+errno_t usb_bus_request_address(usb_bus_t *instance,
     usb_address_t *address, bool strict, usb_speed_t speed);
 
-int usb_bus_get_speed(usb_bus_t *instance,
+errno_t usb_bus_get_speed(usb_bus_t *instance,
     usb_address_t address, usb_speed_t *speed);
 #endif