Changeset b7fd2a0 in mainline for uspace/lib/usbhid/include/usb

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/lib/usbhid/include/usb/hid

Files:

• hiddescriptor.h (modified) (1 diff)
• hidparser.h (modified) (2 diffs)
• hidpath.h (modified) (1 diff)
• hidreport.h (modified) (1 diff)
• request.h (modified) (1 diff)

uspace/lib/usbhid/include/usb/hid/hiddescriptor.h

@@ -43 +43 @@
 #include <usb/hid/hidtypes.h>
 
-int usb_hid_parse_report_descriptor(usb_hid_report_t *report,
+errno_t usb_hid_parse_report_descriptor(usb_hid_report_t *report,
                 const uint8_t *data, size_t size);
 
 void usb_hid_descriptor_print(usb_hid_report_t *report);
 
-int usb_hid_report_init(usb_hid_report_t *report);
+errno_t usb_hid_report_init(usb_hid_report_t *report);
 
 void usb_hid_report_deinit(usb_hid_report_t *report);
 
-int usb_hid_report_append_fields(usb_hid_report_t *report,
+errno_t usb_hid_report_append_fields(usb_hid_report_t *report,
                 usb_hid_report_item_t *report_item);
 

uspace/lib/usbhid/include/usb/hid/hidparser.h

@@ -47 +47 @@
  * Input report parser functions
  */
-int usb_hid_parse_report(const usb_hid_report_t *report, const uint8_t *data,
+errno_t usb_hid_parse_report(const usb_hid_report_t *report, const uint8_t *data,
                 size_t size, uint8_t *report_id);
 
@@ -65 +65 @@
 
 
-int usb_hid_report_output_translate(usb_hid_report_t *report, 
+errno_t usb_hid_report_output_translate(usb_hid_report_t *report, 
                 uint8_t report_id, uint8_t *buffer, size_t size);
 

uspace/lib/usbhid/include/usb/hid/hidpath.h

@@ -118 +118 @@
 void usb_hid_report_path_free(usb_hid_report_path_t *path);
 
-int usb_hid_report_path_set_report_id(usb_hid_report_path_t *usage_path,
+errno_t usb_hid_report_path_set_report_id(usb_hid_report_path_t *usage_path,
                 uint8_t report_id);
 
-int usb_hid_report_path_append_item(usb_hid_report_path_t *usage_path, 
+errno_t usb_hid_report_path_append_item(usb_hid_report_path_t *usage_path, 
                 int32_t usage_page, int32_t usage);
 

uspace/lib/usbhid/include/usb/hid/hidreport.h

@@ -58 +58 @@
  *         usb_pipe_end_session() or usb_request_get_descriptor().
  */
-int usb_hid_process_report_descriptor(usb_device_t *dev, 
+errno_t usb_hid_process_report_descriptor(usb_device_t *dev, 
     usb_hid_report_t *report, uint8_t **report_desc, size_t *report_size);
 

uspace/lib/usbhid/include/usb/hid/request.h

@@ -44 +44 @@
 
 
-int usbhid_req_set_report(usb_pipe_t *ctrl_pipe, int iface_no,
+errno_t usbhid_req_set_report(usb_pipe_t *ctrl_pipe, int iface_no,
     usb_hid_report_type_t type, uint8_t *buffer, size_t buf_size);
 
-int usbhid_req_set_protocol(usb_pipe_t *ctrl_pipe, int iface_no, 
+errno_t usbhid_req_set_protocol(usb_pipe_t *ctrl_pipe, int iface_no, 
     usb_hid_protocol_t protocol);
 
-int usbhid_req_set_idle(usb_pipe_t *ctrl_pipe, int iface_no, uint8_t duration);
+errno_t usbhid_req_set_idle(usb_pipe_t *ctrl_pipe, int iface_no, uint8_t duration);
 
-int usbhid_req_get_report(usb_pipe_t *ctrl_pipe, int iface_no, 
+errno_t usbhid_req_get_report(usb_pipe_t *ctrl_pipe, int iface_no, 
     usb_hid_report_type_t type, uint8_t *buffer, size_t buf_size, 
     size_t *actual_size);
 
-int usbhid_req_get_protocol(usb_pipe_t *ctrl_pipe, int iface_no, 
+errno_t usbhid_req_get_protocol(usb_pipe_t *ctrl_pipe, int iface_no, 
     usb_hid_protocol_t *protocol);
 
-int usbhid_req_get_idle(usb_pipe_t *ctrl_pipe, int iface_no, uint8_t *duration);
+errno_t usbhid_req_get_idle(usb_pipe_t *ctrl_pipe, int iface_no, uint8_t *duration);