Changeset b7fd2a0 in mainline for uspace/lib/usbdev/src/recognise.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/usbdev/src/recognise.c (modified) (5 diffs)

uspace/lib/usbdev/src/recognise.c

@@ -60 +60 @@
  * @return Error code.
  */
-static int usb_add_match_id(match_id_list_t *matches, int score,
+static errno_t usb_add_match_id(match_id_list_t *matches, int score,
     const char *match_str)
 {
@@ -89 +89 @@
                 int __rc = asprintf(&str, format, ##__VA_ARGS__); \
                 if (__rc >= 0) { \
-                        int __rc = usb_add_match_id((match_ids), (score), str); \
+                        errno_t __rc = usb_add_match_id((match_ids), (score), str); \
                         if (__rc != EOK) { \
                                 free(str); \
@@ -108 +108 @@
  * @retval ENOENT Device class is not "use interface".
  */
-int usb_device_create_match_ids_from_interface(
+errno_t usb_device_create_match_ids_from_interface(
     const usb_standard_device_descriptor_t *desc_device,
     const usb_standard_interface_descriptor_t *desc_interface,
@@ -220 +220 @@
  * @return Error code.
  */
-int usb_device_create_match_ids_from_device_descriptor(
+errno_t usb_device_create_match_ids_from_device_descriptor(
     const usb_standard_device_descriptor_t *device_descriptor,
     match_id_list_t *matches)
@@ -264 +264 @@
  * @return Error code.
  */
-int usb_device_create_match_ids(usb_pipe_t *ctrl_pipe,
+errno_t usb_device_create_match_ids(usb_pipe_t *ctrl_pipe,
     match_id_list_t *matches)
 {
         assert(ctrl_pipe);
-        int rc;
+        errno_t rc;
         /*
          * Retrieve device descriptor and add matches from it.