Changeset b7fd2a0 in mainline for uspace/lib/usb

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/lib/usb

Files:

• include/usb/dev.h (modified) (1 diff)
• src/dev.c (modified) (2 diffs)

uspace/lib/usb/include/usb/dev.h

@@ -40 +40 @@
 #include <devman.h>
 
-extern int usb_resolve_device_handle(const char *, devman_handle_t *);
+extern errno_t usb_resolve_device_handle(const char *, devman_handle_t *);
 
 #endif

uspace/lib/usb/src/dev.c

@@ -53 +53 @@
  * @return Error code.
  */
-int usb_resolve_device_handle(const char *dev_path, devman_handle_t *dev_handle)
+errno_t usb_resolve_device_handle(const char *dev_path, devman_handle_t *dev_handle)
 {
         if (dev_path == NULL || dev_handle == NULL) {
@@ -60 +60 @@
 
         /* First, try to get the device handle. */
-        int rc = devman_fun_get_handle(dev_path, dev_handle, 0);
+        errno_t rc = devman_fun_get_handle(dev_path, dev_handle, 0);
 
         /* Next, try parsing dev_handle from the provided string */