Changeset b7fd2a0 in mainline for uspace/lib/label/include

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/lib/label/include

Files:

• label/empty.h (modified) (1 diff)
• label/label.h (modified) (2 diffs)
• types/liblabel.h (modified) (2 diffs)

uspace/lib/label/include/label/empty.h

@@ -41 +41 @@
 #include <types/liblabel.h>
 
-extern int label_bd_is_empty(label_bd_t *, bool *);
-extern int label_bd_empty(label_bd_t *);
-extern int label_part_empty(label_part_t *);
+extern errno_t label_bd_is_empty(label_bd_t *, bool *);
+extern errno_t label_bd_empty(label_bd_t *);
+extern errno_t label_part_empty(label_part_t *);
 
 #endif

uspace/lib/label/include/label/label.h

@@ -40 +40 @@
 #include <types/liblabel.h>
 
-extern int label_open(label_bd_t *, label_t **);
-extern int label_create(label_bd_t *, label_type_t, label_t **);
+extern errno_t label_open(label_bd_t *, label_t **);
+extern errno_t label_create(label_bd_t *, label_type_t, label_t **);
 extern void label_close(label_t *);
-extern int label_destroy(label_t *);
-extern int label_get_info(label_t *, label_info_t *);
+extern errno_t label_destroy(label_t *);
+extern errno_t label_get_info(label_t *, label_info_t *);
 
 extern label_part_t *label_part_first(label_t *);
@@ -50 +50 @@
 extern void label_part_get_info(label_part_t *, label_part_info_t *);
 
-extern int label_part_create(label_t *, label_part_spec_t *,
+extern errno_t label_part_create(label_t *, label_part_spec_t *,
     label_part_t **);
-extern int label_part_destroy(label_part_t *);
+extern errno_t label_part_destroy(label_part_t *);
 extern void label_pspec_init(label_part_spec_t *);
-extern int label_suggest_ptype(label_t *, label_pcnt_t, label_ptype_t *);
+extern errno_t label_suggest_ptype(label_t *, label_pcnt_t, label_ptype_t *);
 
 #endif

uspace/lib/label/include/types/liblabel.h

@@ -54 +54 @@
 /** Ops for individual label type */
 typedef struct {
-        int (*open)(label_bd_t *, label_t **);
-        int (*create)(label_bd_t *, label_t **);
+        errno_t (*open)(label_bd_t *, label_t **);
+        errno_t (*create)(label_bd_t *, label_t **);
         void (*close)(label_t *);
-        int (*destroy)(label_t *);
-        int (*get_info)(label_t *, label_info_t *);
+        errno_t (*destroy)(label_t *);
+        errno_t (*get_info)(label_t *, label_info_t *);
         label_part_t *(*part_first)(label_t *);
         label_part_t *(*part_next)(label_part_t *);
         void (*part_get_info)(label_part_t *, label_part_info_t *);
-        int (*part_create)(label_t *, label_part_spec_t *, label_part_t **);
-        int (*part_destroy)(label_part_t *);
-        int (*suggest_ptype)(label_t *, label_pcnt_t, label_ptype_t *);
+        errno_t (*part_create)(label_t *, label_part_spec_t *, label_part_t **);
+        errno_t (*part_destroy)(label_part_t *);
+        errno_t (*suggest_ptype)(label_t *, label_pcnt_t, label_ptype_t *);
 } label_ops_t;
 
@@ -144 +144 @@
 struct label_bd_ops {
         /** Get block size */
-        int (*get_bsize)(void *, size_t *);
+        errno_t (*get_bsize)(void *, size_t *);
         /** Get number of blocks */
-        int (*get_nblocks)(void *, aoff64_t *);
+        errno_t (*get_nblocks)(void *, aoff64_t *);
         /** Read blocks */
-        int (*read)(void *, aoff64_t, size_t, void *);
+        errno_t (*read)(void *, aoff64_t, size_t, void *);
         /** Write blocks */
-        int (*write)(void *, aoff64_t, size_t, const void *);
+        errno_t (*write)(void *, aoff64_t, size_t, const void *);
 };