Changeset b7fd2a0 in mainline for uspace/lib/drv/include/ddf/driver.h

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/drv/include/ddf/driver.h (modified) (3 diffs)

uspace/lib/drv/include/ddf/driver.h

@@ -56 +56 @@
          * device.
          */
-        int (*open)(ddf_fun_t *);
+        errno_t (*open)(ddf_fun_t *);
         
         /**
@@ -88 +88 @@
 typedef struct driver_ops {
         /** Callback method for passing a new device to the device driver */
-        int (*dev_add)(ddf_dev_t *);
+        errno_t (*dev_add)(ddf_dev_t *);
         
         /** Ask driver to remove a device */
-        int (*dev_remove)(ddf_dev_t *);
+        errno_t (*dev_remove)(ddf_dev_t *);
         
         /** Inform driver a device disappeared */
-        int (*dev_gone)(ddf_dev_t *);
+        errno_t (*dev_gone)(ddf_dev_t *);
         
         /** Ask driver to online a specific function */
-        int (*fun_online)(ddf_fun_t *);
+        errno_t (*fun_online)(ddf_fun_t *);
         
         /** Ask driver to offline a specific function */
-        int (*fun_offline)(ddf_fun_t *);
+        errno_t (*fun_offline)(ddf_fun_t *);
 } driver_ops_t;
 
@@ -124 +124 @@
 extern void *ddf_fun_data_get(ddf_fun_t *);
 extern const char *ddf_fun_get_name(ddf_fun_t *);
-extern int ddf_fun_set_name(ddf_fun_t *, const char *);
+extern errno_t ddf_fun_set_name(ddf_fun_t *, const char *);
 extern ddf_dev_t *ddf_fun_get_dev(ddf_fun_t *);
-extern int ddf_fun_bind(ddf_fun_t *);
-extern int ddf_fun_unbind(ddf_fun_t *);
-extern int ddf_fun_online(ddf_fun_t *);
-extern int ddf_fun_offline(ddf_fun_t *);
-extern int ddf_fun_add_match_id(ddf_fun_t *, const char *, int);
+extern errno_t ddf_fun_bind(ddf_fun_t *);
+extern errno_t ddf_fun_unbind(ddf_fun_t *);
+extern errno_t ddf_fun_online(ddf_fun_t *);
+extern errno_t ddf_fun_offline(ddf_fun_t *);
+extern errno_t ddf_fun_add_match_id(ddf_fun_t *, const char *, int);
 extern void ddf_fun_set_ops(ddf_fun_t *, const ddf_dev_ops_t *);
 extern void ddf_fun_set_conn_handler(ddf_fun_t *, async_port_handler_t);
-extern int ddf_fun_add_to_category(ddf_fun_t *, const char *);
+extern errno_t ddf_fun_add_to_category(ddf_fun_t *, const char *);
 
 #endif