Changeset b7fd2a0 in mainline for uspace/lib/drv/include/audio_mixer_iface.h

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/drv/include/audio_mixer_iface.h (modified) (1 diff)

uspace/lib/drv/include/audio_mixer_iface.h

@@ -43 +43 @@
 #include "ddf/driver.h"
 
-int audio_mixer_get_info(async_exch_t *, const char **, unsigned *);
-int audio_mixer_get_item_info(async_exch_t *, unsigned,
+errno_t audio_mixer_get_info(async_exch_t *, const char **, unsigned *);
+errno_t audio_mixer_get_item_info(async_exch_t *, unsigned,
     const char **, unsigned *);
-int audio_mixer_get_item_level(async_exch_t *, unsigned, unsigned *);
-int audio_mixer_set_item_level(async_exch_t *, unsigned, unsigned);
+errno_t audio_mixer_get_item_level(async_exch_t *, unsigned, unsigned *);
+errno_t audio_mixer_set_item_level(async_exch_t *, unsigned, unsigned);
 
 
 /** Audio mixer communication interface. */
 typedef struct {
-        int (*get_info)(ddf_fun_t *, const char **, unsigned *);
-        int (*get_item_info)(ddf_fun_t *, unsigned, const char **, unsigned *);
-        int (*get_item_level)(ddf_fun_t *, unsigned, unsigned *);
-        int (*set_item_level)(ddf_fun_t *, unsigned, unsigned);
+        errno_t (*get_info)(ddf_fun_t *, const char **, unsigned *);
+        errno_t (*get_item_info)(ddf_fun_t *, unsigned, const char **, unsigned *);
+        errno_t (*get_item_level)(ddf_fun_t *, unsigned, unsigned *);
+        errno_t (*set_item_level)(ddf_fun_t *, unsigned, unsigned);
 } audio_mixer_iface_t;