Changeset b7fd2a0 in mainline for uspace/lib/c/include/ipc

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/lib/c/include/ipc

Files:

• event.h (modified) (1 diff)
• ipc.h (modified) (4 diffs)
• irq.h (modified) (1 diff)

uspace/lib/c/include/ipc/event.h

@@ -39 +39 @@
 #include <types/common.h>
 
-extern int ipc_event_subscribe(event_type_t, sysarg_t);
-extern int ipc_event_task_subscribe(event_task_type_t, sysarg_t);
-extern int ipc_event_unsubscribe(event_type_t);
-extern int ipc_event_task_unsubscribe(event_task_type_t);
-extern int ipc_event_unmask(event_type_t);
-extern int ipc_event_task_unmask(event_task_type_t);
+extern errno_t ipc_event_subscribe(event_type_t, sysarg_t);
+extern errno_t ipc_event_task_subscribe(event_task_type_t, sysarg_t);
+extern errno_t ipc_event_unsubscribe(event_type_t);
+extern errno_t ipc_event_task_unsubscribe(event_task_type_t);
+extern errno_t ipc_event_unmask(event_type_t);
+extern errno_t ipc_event_task_unmask(event_task_type_t);
 
 #endif

uspace/lib/c/include/ipc/ipc.h

@@ -46 +46 @@
 #include <abi/cap.h>
 
-typedef void (*ipc_async_callback_t)(void *, int, ipc_call_t *);
+typedef void (*ipc_async_callback_t)(void *, errno_t, ipc_call_t *);
 
-extern int ipc_wait_cycle(ipc_call_t *, sysarg_t, unsigned int);
+extern errno_t ipc_wait_cycle(ipc_call_t *, sysarg_t, unsigned int);
 extern void ipc_poke(void);
 
@@ -54 +54 @@
         ipc_wait_for_call_timeout(data, SYNCH_NO_TIMEOUT);
 
-extern int ipc_wait_for_call_timeout(ipc_call_t *, sysarg_t);
-extern int ipc_trywait_for_call(ipc_call_t *);
+extern errno_t ipc_wait_for_call_timeout(ipc_call_t *, sysarg_t);
+extern errno_t ipc_trywait_for_call(ipc_call_t *);
 
 /*
@@ -78 +78 @@
             (arg5))
 
-extern int ipc_answer_fast(cap_handle_t, int, sysarg_t, sysarg_t,
+extern errno_t ipc_answer_fast(cap_handle_t, errno_t, sysarg_t, sysarg_t,
     sysarg_t, sysarg_t);
-extern int ipc_answer_slow(cap_handle_t, int, sysarg_t, sysarg_t,
+extern errno_t ipc_answer_slow(cap_handle_t, errno_t, sysarg_t, sysarg_t,
     sysarg_t, sysarg_t, sysarg_t);
 
@@ -115 +115 @@
     sysarg_t, sysarg_t, sysarg_t, void *, ipc_async_callback_t);
 
-extern int ipc_hangup(cap_handle_t);
+extern errno_t ipc_hangup(cap_handle_t);
 
-extern int ipc_forward_fast(cap_handle_t, cap_handle_t, sysarg_t, sysarg_t,
+extern errno_t ipc_forward_fast(cap_handle_t, cap_handle_t, sysarg_t, sysarg_t,
     sysarg_t, unsigned int);
-extern int ipc_forward_slow(cap_handle_t, cap_handle_t, sysarg_t, sysarg_t,
+extern errno_t ipc_forward_slow(cap_handle_t, cap_handle_t, sysarg_t, sysarg_t,
     sysarg_t, sysarg_t, sysarg_t, sysarg_t, unsigned int);
 
-extern int ipc_connect_kbox(task_id_t, cap_handle_t *);
+extern errno_t ipc_connect_kbox(task_id_t, cap_handle_t *);
 
 #endif

uspace/lib/c/include/ipc/irq.h

@@ -40 +40 @@
 #include <abi/cap.h>
 
-extern int ipc_irq_subscribe(int, sysarg_t, const irq_code_t *, cap_handle_t *);
-extern int ipc_irq_unsubscribe(cap_handle_t);
+extern errno_t ipc_irq_subscribe(int, sysarg_t, const irq_code_t *, cap_handle_t *);
+extern errno_t ipc_irq_unsubscribe(cap_handle_t);
 
 #endif