Changeset b7fd2a0 in mainline for uspace/lib/c/include/inet/iplink.h

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/include/inet/iplink.h (modified) (1 diff)

uspace/lib/c/include/inet/iplink.h

@@ -78 +78 @@
 
 typedef struct iplink_ev_ops {
-        int (*recv)(iplink_t *, iplink_recv_sdu_t *, ip_ver_t);
-        int (*change_addr)(iplink_t *, addr48_t);
+        errno_t (*recv)(iplink_t *, iplink_recv_sdu_t *, ip_ver_t);
+        errno_t (*change_addr)(iplink_t *, addr48_t);
 } iplink_ev_ops_t;
 
-extern int iplink_open(async_sess_t *, iplink_ev_ops_t *, void *, iplink_t **);
+extern errno_t iplink_open(async_sess_t *, iplink_ev_ops_t *, void *, iplink_t **);
 extern void iplink_close(iplink_t *);
-extern int iplink_send(iplink_t *, iplink_sdu_t *);
-extern int iplink_send6(iplink_t *, iplink_sdu6_t *);
-extern int iplink_addr_add(iplink_t *, inet_addr_t *);
-extern int iplink_addr_remove(iplink_t *, inet_addr_t *);
-extern int iplink_get_mtu(iplink_t *, size_t *);
-extern int iplink_get_mac48(iplink_t *, addr48_t *);
-extern int iplink_set_mac48(iplink_t *, addr48_t);
+extern errno_t iplink_send(iplink_t *, iplink_sdu_t *);
+extern errno_t iplink_send6(iplink_t *, iplink_sdu6_t *);
+extern errno_t iplink_addr_add(iplink_t *, inet_addr_t *);
+extern errno_t iplink_addr_remove(iplink_t *, inet_addr_t *);
+extern errno_t iplink_get_mtu(iplink_t *, size_t *);
+extern errno_t iplink_get_mac48(iplink_t *, addr48_t *);
+extern errno_t iplink_set_mac48(iplink_t *, addr48_t);
 extern void *iplink_get_userptr(iplink_t *);