Changeset b7fd2a0 in mainline for uspace/lib/c/generic/rtld

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/lib/c/generic/rtld

Files:

• module.c (modified) (1 diff)
• rtld.c (modified) (2 diffs)

uspace/lib/c/generic/rtld/module.c

@@ -54 +54 @@
  * @return EOK on success, ENOMEM if out of memory
  */
-int module_create_static_exec(rtld_t *rtld, module_t **rmodule)
+errno_t module_create_static_exec(rtld_t *rtld, module_t **rmodule)
 {
         module_t *module;

uspace/lib/c/generic/rtld/rtld.c

@@ -45 +45 @@
 
 /** Initialize the runtime linker for use in a statically-linked executable. */
-int rtld_init_static(void)
-{
-        int rc;
+errno_t rtld_init_static(void)
+{
+        errno_t rc;
 
         runtime_env = &rt_env_static;
@@ -70 +70 @@
  * @return EOK on success or non-zero error code
  */
-int rtld_prog_process(elf_finfo_t *p_info, rtld_t **rre)
+errno_t rtld_prog_process(elf_finfo_t *p_info, rtld_t **rre)
 {
         rtld_t *env;