Changeset b7fd2a0 in mainline for uspace/lib/c/generic/io/klog.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/io/klog.c (modified) (1 diff)

uspace/lib/c/generic/io/klog.c

@@ -42 +42 @@
 #include <abi/log.h>
 
-int klog_write(log_level_t lvl, const void *buf, size_t size)
+errno_t klog_write(log_level_t lvl, const void *buf, size_t size)
 {
-        return (int) __SYSCALL4(SYS_KLOG, KLOG_WRITE, (sysarg_t) buf,
+        return (errno_t) __SYSCALL4(SYS_KLOG, KLOG_WRITE, (sysarg_t) buf,
             size, lvl);
 }
 
-int klog_read(void *data, size_t size, size_t *nread)
+errno_t klog_read(void *data, size_t size, size_t *nread)
 {
-        return (int) __SYSCALL5(SYS_KLOG, KLOG_READ, (uintptr_t) data,
+        return (errno_t) __SYSCALL5(SYS_KLOG, KLOG_READ, (uintptr_t) data,
             size, 0, (sysarg_t) nread);
 }