Changeset b7fd2a0 in mainline for uspace/lib/c/generic/dnsr.c

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/dnsr.c (modified) (11 diffs)

uspace/lib/c/generic/dnsr.c

@@ -67 +67 @@
 }
 
-int dnsr_name2host(const char *name, dnsr_hostinfo_t **rinfo, ip_ver_t ver)
+errno_t dnsr_name2host(const char *name, dnsr_hostinfo_t **rinfo, ip_ver_t ver)
 {
         async_exch_t *exch = dnsr_exchange_begin();
@@ -75 +75 @@
             &answer);
         
-        int rc = async_data_write_start(exch, name, str_size(name));
+        errno_t rc = async_data_write_start(exch, name, str_size(name));
         if (rc != EOK) {
                 async_exchange_end(exch);
@@ -90 +90 @@
             sizeof(inet_addr_t), &answer_addr);
         
-        int retval_addr;
+        errno_t retval_addr;
         async_wait_for(req_addr, &retval_addr);
         
@@ -107 +107 @@
         dnsr_exchange_end(exch);
         
-        int retval_cname;
+        errno_t retval_cname;
         async_wait_for(req_cname, &retval_cname);
         
@@ -116 +116 @@
         }
         
-        int retval;
+        errno_t retval;
         async_wait_for(req, &retval);
         
@@ -150 +150 @@
 }
 
-int dnsr_get_srvaddr(inet_addr_t *srvaddr)
+errno_t dnsr_get_srvaddr(inet_addr_t *srvaddr)
 {
         async_exch_t *exch = dnsr_exchange_begin();
@@ -156 +156 @@
         ipc_call_t answer;
         aid_t req = async_send_0(exch, DNSR_GET_SRVADDR, &answer);
-        int rc = async_data_read_start(exch, srvaddr, sizeof(inet_addr_t));
+        errno_t rc = async_data_read_start(exch, srvaddr, sizeof(inet_addr_t));
         
         loc_exchange_end(exch);
@@ -165 +165 @@
         }
         
-        int retval;
+        errno_t retval;
         async_wait_for(req, &retval);
         
@@ -171 +171 @@
 }
 
-int dnsr_set_srvaddr(inet_addr_t *srvaddr)
+errno_t dnsr_set_srvaddr(inet_addr_t *srvaddr)
 {
         async_exch_t *exch = dnsr_exchange_begin();
@@ -177 +177 @@
         ipc_call_t answer;
         aid_t req = async_send_0(exch, DNSR_SET_SRVADDR, &answer);
-        int rc = async_data_write_start(exch, srvaddr, sizeof(inet_addr_t));
+        errno_t rc = async_data_write_start(exch, srvaddr, sizeof(inet_addr_t));
         
         loc_exchange_end(exch);
@@ -186 +186 @@
         }
         
-        int retval;
+        errno_t retval;
         async_wait_for(req, &retval);