Changeset b7fd2a0 in mainline for uspace/lib/c/generic/adt

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/lib/c/generic/adt

Files:

• circ_buf.c (modified) (2 diffs)
• odict.c (modified) (2 diffs)

uspace/lib/c/generic/adt/circ_buf.c

@@ -82 +82 @@
  * @return EOK on success, EAGAIN if circular buffer is full
  */
-int circ_buf_push(circ_buf_t *cbuf, const void *data)
+errno_t circ_buf_push(circ_buf_t *cbuf, const void *data)
 {
         if (circ_buf_nfree(cbuf) == 0)
@@ -99 +99 @@
  * @return EOK on success, EAGAIN if circular buffer is full
  */
-int circ_buf_pop(circ_buf_t *cbuf, void *datab)
+errno_t circ_buf_pop(circ_buf_t *cbuf, void *datab)
 {
         if (cbuf->nused == 0)

uspace/lib/c/generic/adt/odict.c

@@ -92 +92 @@
  * @return EOK on success, EINVAL on failure
  */
-static int odict_validate_tree(odlink_t *cur, int *rbd)
-{
-        int rc;
+static errno_t odict_validate_tree(odlink_t *cur, int *rbd)
+{
+        errno_t rc;
         int bd_a, bd_b;
         int cur_d;
@@ -177 +177 @@
  * @param odict Ordered dictionary
  */
-int odict_validate(odict_t *odict)
+errno_t odict_validate(odict_t *odict)
 {
         int bd;
-        int rc;
+        errno_t rc;
 
         if (odict->root == NULL)