Changeset b7fd2a0 in mainline for uspace/lib/bithenge/src/helenos

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/lib/bithenge/src/helenos

Files:

• block.c (modified) (3 diffs)
• block.h (modified) (1 diff)
• common.h (modified) (2 diffs)

uspace/lib/bithenge/src/helenos/block.c

@@ -61 +61 @@
 }
 
-static int block_size(bithenge_blob_t *base, aoff64_t *size)
+static errno_t block_size(bithenge_blob_t *base, aoff64_t *size)
 {
         block_blob_t *self = blob_as_block(base);
@@ -68 +68 @@
 }
 
-static int block_read(bithenge_blob_t *base, aoff64_t offset, char *buffer,
+static errno_t block_read(bithenge_blob_t *base, aoff64_t offset, char *buffer,
     aoff64_t *size)
 {
@@ -96 +96 @@
  * @param service_id The service ID of the block device.
  * @return EOK on success or an error code from errno.h. */
-int bithenge_new_block_blob(bithenge_node_t **out, service_id_t service_id)
+errno_t bithenge_new_block_blob(bithenge_node_t **out, service_id_t service_id)
 {
         assert(out);
 
         // Initialize libblock
-        int rc;
+        errno_t rc;
         rc = block_init(service_id, 2048);
         if (rc != EOK)

uspace/lib/bithenge/src/helenos/block.h

@@ -41 +41 @@
 #include <bithenge/tree.h>
 
-int bithenge_new_block_blob(bithenge_node_t **, service_id_t);
+errno_t bithenge_new_block_blob(bithenge_node_t **, service_id_t);
 
 #endif

uspace/lib/bithenge/src/helenos/common.h

@@ -64 +64 @@
 }
 
-static inline int string_iterator_next(string_iterator_t *i, wchar_t *out)
+static inline errno_t string_iterator_next(string_iterator_t *i, wchar_t *out)
 {
         *out = i->ch;
@@ -81 +81 @@
 }
 
-static inline int bithenge_parse_int(const char *start, bithenge_int_t *result)
+static inline errno_t bithenge_parse_int(const char *start, bithenge_int_t *result)
 {
         const char *real_start = *start == '-' ? start + 1 : start;
         uint64_t val;
-        int rc = str_uint64_t(real_start, NULL, 10, false, &val);
+        errno_t rc = str_uint64_t(real_start, NULL, 10, false, &val);
         *result = val;
         if (*start == '-')