Changeset b7fd2a0 in mainline for uspace/drv/platform/amdm37x

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/drv/platform/amdm37x

Files:

• amdm37x.c (modified) (2 diffs)
• amdm37x.h (modified) (1 diff)
• main.c (modified) (6 diffs)

uspace/drv/platform/amdm37x/amdm37x.c

@@ -53 +53 @@
 
 
-int amdm37x_init(amdm37x_t *device, bool trace)
+errno_t amdm37x_init(amdm37x_t *device, bool trace)
 {
         assert(device);
-        int ret = EOK;
+        errno_t ret = EOK;
 
         ret = pio_enable((void*)USBHOST_CM_BASE_ADDRESS, USBHOST_CM_SIZE,
@@ -358 +358 @@
  * Select mode than can operate in FS/LS.
  */
-int amdm37x_usb_tll_init(amdm37x_t *device)
+errno_t amdm37x_usb_tll_init(amdm37x_t *device)
 {
         /* Check access */

uspace/drv/platform/amdm37x/amdm37x.h

@@ -66 +66 @@
 } amdm37x_t;
 
-int amdm37x_init(amdm37x_t *device, bool trace_io);
-int amdm37x_usb_tll_init(amdm37x_t *device);
+errno_t amdm37x_init(amdm37x_t *device, bool trace_io);
+errno_t amdm37x_usb_tll_init(amdm37x_t *device);
 void amdm37x_setup_dpll_on_autoidle(amdm37x_t *device);
 void amdm37x_usb_clocks_set(amdm37x_t *device, bool enabled);

uspace/drv/platform/amdm37x/main.c

@@ -150 +150 @@
 
 static hw_resource_list_t *amdm37x_get_resources(ddf_fun_t *fnode);
-static int amdm37x_enable_interrupt(ddf_fun_t *fun, int);
+static errno_t amdm37x_enable_interrupt(ddf_fun_t *fun, int);
 
 static hw_res_ops_t fun_hw_res_ops = {
@@ -161 +161 @@
 };
 
-static int amdm37x_add_fun(ddf_dev_t *dev, const amdm37x_fun_t *fun)
+static errno_t amdm37x_add_fun(ddf_dev_t *dev, const amdm37x_fun_t *fun)
 {
         assert(dev);
@@ -174 +174 @@
         
         /* Add match id */
-        int ret = ddf_fun_add_match_id(fnode,
+        errno_t ret = ddf_fun_add_match_id(fnode,
             fun->match_id.id, fun->match_id.score);
         if (ret != EOK) {
@@ -212 +212 @@
  *
  */
-static int amdm37x_dev_add(ddf_dev_t *dev)
+static errno_t amdm37x_dev_add(ddf_dev_t *dev)
 {
         assert(dev);
@@ -218 +218 @@
         if (!device)
                 return ENOMEM;
-        int ret = amdm37x_init(device, DEBUG_CM);
+        errno_t ret = amdm37x_init(device, DEBUG_CM);
         if (ret != EOK) {
                 ddf_msg(LVL_FATAL, "Failed to setup hw access!.\n");
@@ -265 +265 @@
 }
 
-static int amdm37x_enable_interrupt(ddf_fun_t *fun, int irq)
+static errno_t amdm37x_enable_interrupt(ddf_fun_t *fun, int irq)
 {
         //TODO: Implement