Changeset b7fd2a0 in mainline for uspace/drv/intctl/apic

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/drv/intctl/apic

Files:

• apic.c (modified) (4 diffs)
• apic.h (modified) (1 diff)
• main.c (modified) (7 diffs)

uspace/drv/intctl/apic/apic.c

@@ -140 +140 @@
 }
 
-static int apic_enable_irq(apic_t *apic, sysarg_t irq)
+static errno_t apic_enable_irq(apic_t *apic, sysarg_t irq)
 {
         io_redirection_reg_t reg;
@@ -207 +207 @@
 
 /** Add APIC device. */
-int apic_add(apic_t *apic, apic_res_t *res)
+errno_t apic_add(apic_t *apic, apic_res_t *res)
 {
         sysarg_t have_apic;
         ddf_fun_t *fun_a = NULL;
         void *regs;
-        int rc;
+        errno_t rc;
         
         if ((sysinfo_get_value("apic", &have_apic) != EOK) || (!have_apic)) {
@@ -254 +254 @@
 
 /** Remove APIC device */
-int apic_remove(apic_t *apic)
+errno_t apic_remove(apic_t *apic)
 {
         return ENOTSUP;
@@ -260 +260 @@
 
 /** APIC device gone */
-int apic_gone(apic_t *apic)
+errno_t apic_gone(apic_t *apic)
 {
         return ENOTSUP;

uspace/drv/intctl/apic/apic.h

@@ -52 +52 @@
 } apic_t;
 
-extern int apic_add(apic_t *, apic_res_t *);
-extern int apic_remove(apic_t *);
-extern int apic_gone(apic_t *);
+extern errno_t apic_add(apic_t *, apic_res_t *);
+extern errno_t apic_remove(apic_t *);
+extern errno_t apic_gone(apic_t *);
 
 #endif

uspace/drv/intctl/apic/main.c

@@ -43 +43 @@
 #define NAME  "apic"
 
-static int apic_dev_add(ddf_dev_t *dev);
-static int apic_dev_remove(ddf_dev_t *dev);
-static int apic_dev_gone(ddf_dev_t *dev);
-static int apic_fun_online(ddf_fun_t *fun);
-static int apic_fun_offline(ddf_fun_t *fun);
+static errno_t apic_dev_add(ddf_dev_t *dev);
+static errno_t apic_dev_remove(ddf_dev_t *dev);
+static errno_t apic_dev_gone(ddf_dev_t *dev);
+static errno_t apic_fun_online(ddf_fun_t *fun);
+static errno_t apic_fun_offline(ddf_fun_t *fun);
 
 static driver_ops_t driver_ops = {
@@ -62 +62 @@
 };
 
-static int apic_get_res(ddf_dev_t *dev, apic_res_t *res)
+static errno_t apic_get_res(ddf_dev_t *dev, apic_res_t *res)
 {
         async_sess_t *parent_sess;
         hw_res_list_parsed_t hw_res;
-        int rc;
+        errno_t rc;
 
         parent_sess = ddf_dev_parent_sess_get(dev);
@@ -90 +90 @@
 }
 
-static int apic_dev_add(ddf_dev_t *dev)
+static errno_t apic_dev_add(ddf_dev_t *dev)
 {
         apic_t *apic;
         apic_res_t apic_res;
-        int rc;
+        errno_t rc;
 
         ddf_msg(LVL_DEBUG, "apic_dev_add(%p)", dev);
@@ -114 +114 @@
 }
 
-static int apic_dev_remove(ddf_dev_t *dev)
+static errno_t apic_dev_remove(ddf_dev_t *dev)
 {
         apic_t *apic = (apic_t *)ddf_dev_data_get(dev);
@@ -123 +123 @@
 }
 
-static int apic_dev_gone(ddf_dev_t *dev)
+static errno_t apic_dev_gone(ddf_dev_t *dev)
 {
         apic_t *apic = (apic_t *)ddf_dev_data_get(dev);
@@ -132 +132 @@
 }
 
-static int apic_fun_online(ddf_fun_t *fun)
+static errno_t apic_fun_online(ddf_fun_t *fun)
 {
         ddf_msg(LVL_DEBUG, "apic_fun_online()");
@@ -138 +138 @@
 }
 
-static int apic_fun_offline(ddf_fun_t *fun)
+static errno_t apic_fun_offline(ddf_fun_t *fun)
 {
         ddf_msg(LVL_DEBUG, "apic_fun_offline()");