Changeset b7fd2a0 in mainline for uspace/drv/hid/xtkbd

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/drv/hid/xtkbd

Files:

• main.c (modified) (2 diffs)
• xtkbd.c (modified) (3 diffs)
• xtkbd.h (modified) (1 diff)

uspace/drv/hid/xtkbd/main.c

@@ -46 +46 @@
 #define NAME "xtkbd"
 
-static int xt_kbd_add(ddf_dev_t *device);
+static errno_t xt_kbd_add(ddf_dev_t *device);
 
 /** DDF driver ops. */
@@ -83 +83 @@
  *
  */
-static int xt_kbd_add(ddf_dev_t *device)
+static errno_t xt_kbd_add(ddf_dev_t *device)
 {
-        int rc;
+        errno_t rc;
 
         if (!device)

uspace/drv/hid/xtkbd/xtkbd.c

@@ -205 +205 @@
  *
  */
-static int polling(void *arg)
+static errno_t polling(void *arg)
 {
         xt_kbd_t *kbd = arg;
         size_t nread;
-        int rc;
+        errno_t rc;
         
         while (true) {
@@ -353 +353 @@
                 
                 size_t nwr;
-                int rc = chardev_write(kbd->chardev, &cmds[0], 1, &nwr);
+                errno_t rc = chardev_write(kbd->chardev, &cmds[0], 1, &nwr);
                 if (rc != EOK) {
                         async_answer_0(icallid, rc);
@@ -410 +410 @@
  *
  */
-int xt_kbd_init(xt_kbd_t *kbd, ddf_dev_t *dev)
+errno_t xt_kbd_init(xt_kbd_t *kbd, ddf_dev_t *dev)
 {
         async_sess_t *parent_sess;
         bool bound = false;
-        int rc;
+        errno_t rc;
         
         kbd->client_sess = NULL;

uspace/drv/hid/xtkbd/xtkbd.h

@@ -55 +55 @@
 } xt_kbd_t;
 
-extern int xt_kbd_init(xt_kbd_t *, ddf_dev_t *);
+extern errno_t xt_kbd_init(xt_kbd_t *, ddf_dev_t *);
 
 #endif