Changeset b7fd2a0 in mainline for uspace/drv/hid/atkbd

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/drv/hid/atkbd

Files:

• atkbd.c (modified) (3 diffs)
• atkbd.h (modified) (1 diff)
• main.c (modified) (2 diffs)

uspace/drv/hid/atkbd/atkbd.c

@@ -200 +200 @@
  *
  */
-static int polling(void *arg)
+static errno_t polling(void *arg)
 {
         at_kbd_t *kbd = arg;
         size_t nwr;
-        int rc;
+        errno_t rc;
         
         while (true) {
@@ -355 +355 @@
  *
  */
-int at_kbd_init(at_kbd_t *kbd, ddf_dev_t *dev)
+errno_t at_kbd_init(at_kbd_t *kbd, ddf_dev_t *dev)
 {
         async_sess_t *parent_sess;
-        int rc;
+        errno_t rc;
         
         assert(kbd);
@@ -385 +385 @@
         ddf_fun_set_ops(kbd->kbd_fun, &kbd_ops);
         
-        int ret = ddf_fun_bind(kbd->kbd_fun);
+        errno_t ret = ddf_fun_bind(kbd->kbd_fun);
         if (ret != EOK) {
                 ddf_msg(LVL_ERROR, "Failed binding function 'kbd'.");

uspace/drv/hid/atkbd/atkbd.h

@@ -54 +54 @@
 } at_kbd_t;
 
-extern int at_kbd_init(at_kbd_t *, ddf_dev_t *);
+extern errno_t at_kbd_init(at_kbd_t *, ddf_dev_t *);
 
 #endif

uspace/drv/hid/atkbd/main.c

@@ -46 +46 @@
 #define NAME "atkbd"
 
-static int at_kbd_add(ddf_dev_t *device);
+static errno_t at_kbd_add(ddf_dev_t *device);
 
 /** DDF driver ops. */
@@ -83 +83 @@
  *
  */
-static int at_kbd_add(ddf_dev_t *device)
+static errno_t at_kbd_add(ddf_dev_t *device)
 {
-        int rc;
+        errno_t rc;
 
         if (!device)