Changeset b7fd2a0 in mainline for uspace/drv/hid/adb-mouse

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/drv/hid/adb-mouse

Files:

• adb-mouse.c (modified) (4 diffs)
• adb-mouse.h (modified) (1 diff)
• main.c (modified) (6 diffs)

uspace/drv/hid/adb-mouse/adb-mouse.c

@@ -97 +97 @@
                 ipc_callid_t callid = async_get_call(&call);
 
-                int retval = EOK;
+                errno_t retval = EOK;
 
                 if (!IPC_GET_IMETHOD(call)) {
@@ -117 +117 @@
 
 /** Add ADB mouse device */
-int adb_mouse_add(adb_mouse_t *mouse)
-{
-        int rc;
+errno_t adb_mouse_add(adb_mouse_t *mouse)
+{
+        errno_t rc;
         bool bound = false;
 
@@ -188 +188 @@
 
 /** Remove ADB mouse device */
-int adb_mouse_remove(adb_mouse_t *con)
+errno_t adb_mouse_remove(adb_mouse_t *con)
 {
         return ENOTSUP;
@@ -194 +194 @@
 
 /** ADB mouse device gone */
-int adb_mouse_gone(adb_mouse_t *con)
+errno_t adb_mouse_gone(adb_mouse_t *con)
 {
         return ENOTSUP;

uspace/drv/hid/adb-mouse/adb-mouse.h

@@ -47 +47 @@
 } adb_mouse_t;
 
-extern int adb_mouse_add(adb_mouse_t *);
-extern int adb_mouse_remove(adb_mouse_t *);
-extern int adb_mouse_gone(adb_mouse_t *);
+extern errno_t adb_mouse_add(adb_mouse_t *);
+extern errno_t adb_mouse_remove(adb_mouse_t *);
+extern errno_t adb_mouse_gone(adb_mouse_t *);
 
 #endif

uspace/drv/hid/adb-mouse/main.c

@@ -42 +42 @@
 #define NAME  "adb-mouse"
 
-static int adb_mouse_dev_add(ddf_dev_t *dev);
-static int adb_mouse_dev_remove(ddf_dev_t *dev);
-static int adb_mouse_dev_gone(ddf_dev_t *dev);
-static int adb_mouse_fun_online(ddf_fun_t *fun);
-static int adb_mouse_fun_offline(ddf_fun_t *fun);
+static errno_t adb_mouse_dev_add(ddf_dev_t *dev);
+static errno_t adb_mouse_dev_remove(ddf_dev_t *dev);
+static errno_t adb_mouse_dev_gone(ddf_dev_t *dev);
+static errno_t adb_mouse_fun_online(ddf_fun_t *fun);
+static errno_t adb_mouse_fun_offline(ddf_fun_t *fun);
 
 static driver_ops_t driver_ops = {
@@ -61 +61 @@
 };
 
-static int adb_mouse_dev_add(ddf_dev_t *dev)
+static errno_t adb_mouse_dev_add(ddf_dev_t *dev)
 {
         adb_mouse_t *adb_mouse;
@@ -77 +77 @@
 }
 
-static int adb_mouse_dev_remove(ddf_dev_t *dev)
+static errno_t adb_mouse_dev_remove(ddf_dev_t *dev)
 {
         adb_mouse_t *adb_mouse = (adb_mouse_t *)ddf_dev_data_get(dev);
@@ -86 +86 @@
 }
 
-static int adb_mouse_dev_gone(ddf_dev_t *dev)
+static errno_t adb_mouse_dev_gone(ddf_dev_t *dev)
 {
         adb_mouse_t *adb_mouse = (adb_mouse_t *)ddf_dev_data_get(dev);
@@ -95 +95 @@
 }
 
-static int adb_mouse_fun_online(ddf_fun_t *fun)
+static errno_t adb_mouse_fun_online(ddf_fun_t *fun)
 {
         ddf_msg(LVL_DEBUG, "adb_mouse_fun_online()");
@@ -101 +101 @@
 }
 
-static int adb_mouse_fun_offline(ddf_fun_t *fun)
+static errno_t adb_mouse_fun_offline(ddf_fun_t *fun)
 {
         ddf_msg(LVL_DEBUG, "adb_mouse_fun_offline()");