Changeset b7fd2a0 in mainline for uspace/drv/char/sun4v-con


Ignore:
Timestamp:
2018-01-13T03:10:29Z (8 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:
uspace/drv/char/sun4v-con
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • uspace/drv/char/sun4v-con/main.c

    r36f0738 rb7fd2a0  
    4040#define NAME  "sun4v-con"
    4141
    42 static int sun4v_con_dev_add(ddf_dev_t *dev);
    43 static int sun4v_con_dev_remove(ddf_dev_t *dev);
    44 static int sun4v_con_dev_gone(ddf_dev_t *dev);
    45 static int sun4v_con_fun_online(ddf_fun_t *fun);
    46 static int sun4v_con_fun_offline(ddf_fun_t *fun);
     42static errno_t sun4v_con_dev_add(ddf_dev_t *dev);
     43static errno_t sun4v_con_dev_remove(ddf_dev_t *dev);
     44static errno_t sun4v_con_dev_gone(ddf_dev_t *dev);
     45static errno_t sun4v_con_fun_online(ddf_fun_t *fun);
     46static errno_t sun4v_con_fun_offline(ddf_fun_t *fun);
    4747
    4848static driver_ops_t driver_ops = {
    … …  
    5959};
    6060
    61 static int sun4v_con_get_res(ddf_dev_t *dev, sun4v_con_res_t *res)
     61static errno_t sun4v_con_get_res(ddf_dev_t *dev, sun4v_con_res_t *res)
    6262{
    6363        async_sess_t *parent_sess;
    6464        hw_res_list_parsed_t hw_res;
    65         int rc;
     65        errno_t rc;
    6666
    6767        parent_sess = ddf_dev_parent_sess_get(dev);
    … …  
    8888
    8989
    90 static int sun4v_con_dev_add(ddf_dev_t *dev)
     90static errno_t sun4v_con_dev_add(ddf_dev_t *dev)
    9191{
    9292        sun4v_con_t *sun4v_con;
    9393        sun4v_con_res_t res;
    94         int rc;
     94        errno_t rc;
    9595
    9696        ddf_msg(LVL_DEBUG, "sun4v_con_dev_add(%p)", dev);
    … …  
    112112}
    113113
    114 static int sun4v_con_dev_remove(ddf_dev_t *dev)
     114static errno_t sun4v_con_dev_remove(ddf_dev_t *dev)
    115115{
    116116        sun4v_con_t *sun4v_con = (sun4v_con_t *)ddf_dev_data_get(dev);
    … …  
    121121}
    122122
    123 static int sun4v_con_dev_gone(ddf_dev_t *dev)
     123static errno_t sun4v_con_dev_gone(ddf_dev_t *dev)
    124124{
    125125        sun4v_con_t *sun4v_con = (sun4v_con_t *)ddf_dev_data_get(dev);
    … …  
    130130}
    131131
    132 static int sun4v_con_fun_online(ddf_fun_t *fun)
     132static errno_t sun4v_con_fun_online(ddf_fun_t *fun)
    133133{
    134134        ddf_msg(LVL_DEBUG, "sun4v_con_fun_online()");
    … …  
    136136}
    137137
    138 static int sun4v_con_fun_offline(ddf_fun_t *fun)
     138static errno_t sun4v_con_fun_offline(ddf_fun_t *fun)
    139139{
    140140        ddf_msg(LVL_DEBUG, "sun4v_con_fun_offline()");

  • uspace/drv/char/sun4v-con/sun4v-con.c

    r36f0738 rb7fd2a0  
    4646#define POLL_INTERVAL  10000
    4747
    48 static int sun4v_con_read(chardev_srv_t *, void *, size_t, size_t *);
    49 static int sun4v_con_write(chardev_srv_t *, const void *, size_t, size_t *);
     48static errno_t sun4v_con_read(chardev_srv_t *, void *, size_t, size_t *);
     49static errno_t sun4v_con_write(chardev_srv_t *, const void *, size_t, size_t *);
    5050
    5151static chardev_ops_t sun4v_con_chardev_ops = {
    … …  
    6969
    7070/** Add sun4v console device. */
    71 int sun4v_con_add(sun4v_con_t *con, sun4v_con_res_t *res)
     71errno_t sun4v_con_add(sun4v_con_t *con, sun4v_con_res_t *res)
    7272{
    7373        ddf_fun_t *fun = NULL;
    74         int rc;
     74        errno_t rc;
    7575
    7676        con->res = *res;
    … …  
    129129
    130130/** Remove sun4v console device */
    131 int sun4v_con_remove(sun4v_con_t *con)
     131errno_t sun4v_con_remove(sun4v_con_t *con)
    132132{
    133133        return ENOTSUP;
    … …  
    135135
    136136/** Msim console device gone */
    137 int sun4v_con_gone(sun4v_con_t *con)
     137errno_t sun4v_con_gone(sun4v_con_t *con)
    138138{
    139139        return ENOTSUP;
    … …  
    141141
    142142/** Read from Sun4v console device */
    143 static int sun4v_con_read(chardev_srv_t *srv, void *buf, size_t size,
     143static errno_t sun4v_con_read(chardev_srv_t *srv, void *buf, size_t size,
    144144    size_t *nread)
    145145{
    … …  
    165165
    166166/** Write to Sun4v console device */
    167 static int sun4v_con_write(chardev_srv_t *srv, const void *data, size_t size,
     167static errno_t sun4v_con_write(chardev_srv_t *srv, const void *data, size_t size,
    168168    size_t *nwr)
    169169{

  • uspace/drv/char/sun4v-con/sun4v-con.h

    r36f0738 rb7fd2a0  
    6262} sun4v_con_t;
    6363
    64 extern int sun4v_con_add(sun4v_con_t *, sun4v_con_res_t *);
    65 extern int sun4v_con_remove(sun4v_con_t *);
    66 extern int sun4v_con_gone(sun4v_con_t *);
     64extern errno_t sun4v_con_add(sun4v_con_t *, sun4v_con_res_t *);
     65extern errno_t sun4v_con_remove(sun4v_con_t *);
     66extern errno_t sun4v_con_gone(sun4v_con_t *);
    6767
    6868#endif
Note: See TracChangeset for help on using the changeset viewer.