Changeset b7fd2a0 in mainline for uspace/drv/bus/usb/vhc/hub


Ignore:
Timestamp:
2018-01-13T03:10:29Z (8 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:
uspace/drv/bus/usb/vhc/hub
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • uspace/drv/bus/usb/vhc/hub/hub.c

    r36f0738 rb7fd2a0  
    6363static void set_port_status_change(hub_port_t *, hub_status_change_t);
    6464static void clear_port_status_change(hub_port_t *, uint16_t);
    65 static int set_port_state_delayed_fibril(void *);
     65static errno_t set_port_state_delayed_fibril(void *);
    6666static void set_port_state_delayed(hub_t *, size_t, suseconds_t,
    6767    hub_port_state_t, hub_port_state_t);
    … …  
    163163 * @return Error code.
    164164 */
    165 int hub_disconnect_device(hub_t *hub, void *device)
     165errno_t hub_disconnect_device(hub_t *hub, void *device)
    166166{
    167167        size_t index = hub_find_device(hub, device);
    … …  
    461461 * @return Always EOK.
    462462 */
    463 static int set_port_state_delayed_fibril(void *arg)
     463static errno_t set_port_state_delayed_fibril(void *arg)
    464464{
    465465        struct delay_port_state_change *change

  • uspace/drv/bus/usb/vhc/hub/hub.h

    r36f0738 rb7fd2a0  
    102102void hub_init(hub_t *);
    103103size_t hub_connect_device(hub_t *, void *);
    104 int hub_disconnect_device(hub_t *, void *);
     104errno_t hub_disconnect_device(hub_t *, void *);
    105105size_t hub_find_device(hub_t *, void *);
    106106void hub_acquire(hub_t *);

  • uspace/drv/bus/usb/vhc/hub/virthub.c

    r36f0738 rb7fd2a0  
    147147 * @return Error code.
    148148 */
    149 int virthub_init(usbvirt_device_t *dev, const char* name)
     149errno_t virthub_init(usbvirt_device_t *dev, const char* name)
    150150{
    151151        if (dev == NULL) {
    … …  
    197197 * @return Error code.
    198198 */
    199 int virthub_disconnect_device(usbvirt_device_t *dev, vhc_virtdev_t *conn)
     199errno_t virthub_disconnect_device(usbvirt_device_t *dev, vhc_virtdev_t *conn)
    200200{
    201201        assert(dev != NULL);

  • uspace/drv/bus/usb/vhc/hub/virthub.h

    r36f0738 rb7fd2a0  
    8080extern hub_descriptor_t hub_descriptor;
    8181
    82 int virthub_init(usbvirt_device_t *, const char *name);
     82errno_t virthub_init(usbvirt_device_t *, const char *name);
    8383int virthub_connect_device(usbvirt_device_t *, vhc_virtdev_t *);
    84 int virthub_disconnect_device(usbvirt_device_t *, vhc_virtdev_t *);
     84errno_t virthub_disconnect_device(usbvirt_device_t *, vhc_virtdev_t *);
    8585bool virthub_is_device_enabled(usbvirt_device_t *, vhc_virtdev_t *);
    8686void virthub_get_status(usbvirt_device_t *, char *, size_t);

  • uspace/drv/bus/usb/vhc/hub/virthubops.c

    r36f0738 rb7fd2a0  
    6363
    6464/** Callback for data request. */
    65 static int req_on_status_change_pipe(usbvirt_device_t *dev,
     65static errno_t req_on_status_change_pipe(usbvirt_device_t *dev,
    6666    usb_endpoint_t endpoint, usb_transfer_type_t tr_type,
    6767    void *buffer, size_t buffer_size, size_t *actual_size)
    … …  
    109109 * @return Error code.
    110110 */
    111 static int req_clear_hub_feature(usbvirt_device_t *dev,
     111static errno_t req_clear_hub_feature(usbvirt_device_t *dev,
    112112    const usb_device_request_setup_packet_t *request, uint8_t *data,
    113113    size_t *act_size)
    … …  
    123123 * @return Error code.
    124124 */
    125 static int req_clear_port_feature(usbvirt_device_t *dev,
    126     const usb_device_request_setup_packet_t *request, uint8_t *data,
    127     size_t *act_size)
    128 {
    129         int rc;
     125static errno_t req_clear_port_feature(usbvirt_device_t *dev,
     126    const usb_device_request_setup_packet_t *request, uint8_t *data,
     127    size_t *act_size)
     128{
     129        errno_t rc;
    130130        size_t port = request->index - 1;
    131131        usb_hub_class_feature_t feature = request->value;
    … …  
    203203 * @return Error code.
    204204 */
    205 static int req_get_bus_state(usbvirt_device_t *dev,
     205static errno_t req_get_bus_state(usbvirt_device_t *dev,
    206206    const usb_device_request_setup_packet_t *request, uint8_t *data,
    207207    size_t *act_size)
    … …  
    217217 * @return Error code.
    218218 */
    219 static int req_get_descriptor(usbvirt_device_t *dev,
     219static errno_t req_get_descriptor(usbvirt_device_t *dev,
    220220    const usb_device_request_setup_packet_t *request, uint8_t *data,
    221221    size_t *act_size)
    … …  
    238238 * @return Error code.
    239239 */
    240 static int req_get_hub_status(usbvirt_device_t *dev,
     240static errno_t req_get_hub_status(usbvirt_device_t *dev,
    241241    const usb_device_request_setup_packet_t *request, uint8_t *data,
    242242    size_t *act_size)
    … …  
    257257 * @return Error code.
    258258 */
    259 static int req_get_port_status(usbvirt_device_t *dev,
     259static errno_t req_get_port_status(usbvirt_device_t *dev,
    260260    const usb_device_request_setup_packet_t *request, uint8_t *data,
    261261    size_t *act_size)
    … …  
    282282 * @return Error code.
    283283 */
    284 static int req_set_hub_feature(usbvirt_device_t *dev,
     284static errno_t req_set_hub_feature(usbvirt_device_t *dev,
    285285    const usb_device_request_setup_packet_t *request, uint8_t *data,
    286286    size_t *act_size)
    … …  
    296296 * @return Error code.
    297297 */
    298 static int req_set_port_feature(usbvirt_device_t *dev,
    299     const usb_device_request_setup_packet_t *request, uint8_t *data,
    300     size_t *act_size)
    301 {
    302         int rc = ENOTSUP;
     298static errno_t req_set_port_feature(usbvirt_device_t *dev,
     299    const usb_device_request_setup_packet_t *request, uint8_t *data,
     300    size_t *act_size)
     301{
     302        errno_t rc = ENOTSUP;
    303303        size_t port = request->index - 1;
    304304        usb_hub_class_feature_t feature = request->value;
Note: See TracChangeset for help on using the changeset viewer.