Changeset b7fd2a0 in mainline for uspace/app/tetris

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/app/tetris

Files:

• scores.c (modified) (1 diff)
• scores.h (modified) (1 diff)
• screen.c (modified) (2 diffs)

uspace/app/tetris/scores.c

@@ -205 +205 @@
 }
 
-int loadscores(void)
+errno_t loadscores(void)
 {
         FILE *f;

uspace/app/tetris/scores.h

@@ -72 +72 @@
 extern void initscores(void);
 extern void insertscore(int score, int level);
-extern int loadscores(void);
+extern errno_t loadscores(void);
 extern void savescores(void);
 

uspace/app/tetris/screen.c

@@ -138 +138 @@
 winsize_t winsize;
 
-static int get_display_size(winsize_t *ws)
+static errno_t get_display_size(winsize_t *ws)
 {
         return console_get_size(console, &ws->ws_col, &ws->ws_row);
@@ -146 +146 @@
 {
         sysarg_t ccap;
-        int rc = console_get_color_cap(console, &ccap);
+        errno_t rc = console_get_color_cap(console, &ccap);
         
         if (rc != 0)