Changeset b7fd2a0 in mainline for uspace/app/netecho

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

uspace/app/netecho

Files:

• comm.c (modified) (4 diffs)
• comm.h (modified) (1 diff)
• netecho.c (modified) (3 diffs)

uspace/app/netecho/comm.c

@@ -71 +71 @@
         size_t pos;
         size_t now;
-        int rc;
+        errno_t rc;
 
         size = udp_rmsg_size(rmsg);
@@ -109 +109 @@
 }
 
-int comm_open_listen(const char *port_s)
+errno_t comm_open_listen(const char *port_s)
 {
         inet_ep2_t epp;
-        int rc;
+        errno_t rc;
 
         char *endptr;
@@ -142 +142 @@
 }
 
-int comm_open_talkto(const char *hostport)
+errno_t comm_open_talkto(const char *hostport)
 {
         inet_ep2_t epp;
         const char *errmsg;
-        int rc;
+        errno_t rc;
 
         inet_ep2_init(&epp);
@@ -182 +182 @@
 }
 
-int comm_send(void *data, size_t size)
+errno_t comm_send(void *data, size_t size)
 {
-        int rc = udp_assoc_send_msg(assoc, &remote, data, size);
+        errno_t rc = udp_assoc_send_msg(assoc, &remote, data, size);
         if (rc != EOK)
                 return EIO;

uspace/app/netecho/comm.h

@@ -39 +39 @@
 #include <stddef.h>
 
-extern int comm_open_listen(const char *);
-extern int comm_open_talkto(const char *);
+extern errno_t comm_open_listen(const char *);
+extern errno_t comm_open_talkto(const char *);
 extern void comm_close(void);
-extern int comm_send(void *, size_t);
+extern errno_t comm_send(void *, size_t);
 
 #endif

uspace/app/netecho/netecho.c

@@ -75 +75 @@
         char cbuf[STR_BOUNDS(1)];
         size_t offs;
-        int rc;
+        errno_t rc;
 
         offs = 0;
@@ -137 +137 @@
 static void netecho_send_messages(char **msgs)
 {
-        int rc;
+        errno_t rc;
 
         while (*msgs != NULL) {
@@ -154 +154 @@
         char *port;
         char **msgs;
-        int rc;
+        errno_t rc;
 
         if (argc < 2) {