Changeset b7fd2a0 in mainline for kernel/generic/src/udebug

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

kernel/generic/src/udebug

Files:

• udebug.c (modified) (1 diff)
• udebug_ipc.c (modified) (10 diffs)
• udebug_ops.c (modified) (13 diffs)

kernel/generic/src/udebug/udebug.c

@@ -397 +397 @@
  *
  */
-int udebug_task_cleanup(struct task *task)
+errno_t udebug_task_cleanup(struct task *task)
 {
         assert(mutex_locked(&task->udebug.lock));

kernel/generic/src/udebug/udebug_ipc.c

@@ -51 +51 @@
 #include <udebug/udebug_ipc.h>
 
-int udebug_request_preprocess(call_t *call, phone_t *phone)
+errno_t udebug_request_preprocess(call_t *call, phone_t *phone)
 {
         switch (IPC_GET_ARG1(call->data)) {
@@ -71 +71 @@
 static void udebug_receive_begin(call_t *call)
 {
-        int rc;
+        errno_t rc;
         bool active;
 
@@ -98 +98 @@
 static void udebug_receive_end(call_t *call)
 {
-        int rc;
+        errno_t rc;
 
         rc = udebug_end();
@@ -113 +113 @@
 static void udebug_receive_set_evmask(call_t *call)
 {
-        int rc;
+        errno_t rc;
         udebug_evmask_t mask;
 
@@ -132 +132 @@
 {
         thread_t *t;
-        int rc;
+        errno_t rc;
 
         t = (thread_t *)IPC_GET_ARG2(call->data);
@@ -152 +152 @@
 {
         thread_t *t;
-        int rc;
+        errno_t rc;
 
         t = (thread_t *)IPC_GET_ARG2(call->data);
@@ -172 +172 @@
         void *buffer;
         size_t copied, needed;
-        int rc;
+        errno_t rc;
 
         uspace_addr = IPC_GET_ARG2(call->data); /* Destination address */
@@ -307 +307 @@
         thread_t *t;
         sysarg_t uspace_addr;
-        int rc;
+        errno_t rc;
         void *buffer;
 
@@ -346 +346 @@
         sysarg_t to_copy;
         void *buffer = NULL;
-        int rc;
+        errno_t rc;
 
         t = (thread_t *) IPC_GET_ARG2(call->data);
@@ -390 +390 @@
         unsigned size;
         void *buffer = NULL;
-        int rc;
+        errno_t rc;
 
         uspace_dst = IPC_GET_ARG2(call->data);

kernel/generic/src/udebug/udebug_ops.c

@@ -79 +79 @@
  *
  */
-static int _thread_op_begin(thread_t *thread, bool being_go)
+static errno_t _thread_op_begin(thread_t *thread, bool being_go)
 {
         mutex_lock(&TASK->udebug.lock);
@@ -174 +174 @@
  *         debugging session.
  */
-int udebug_begin(call_t *call, bool *active)
+errno_t udebug_begin(call_t *call, bool *active)
 {
         LOG("Debugging task %" PRIu64, TASK->taskid);
@@ -219 +219 @@
  *
  */
-int udebug_end(void)
+errno_t udebug_end(void)
 {
         LOG("Task %" PRIu64, TASK->taskid);
         
         mutex_lock(&TASK->udebug.lock);
-        int rc = udebug_task_cleanup(TASK);
+        errno_t rc = udebug_task_cleanup(TASK);
         mutex_unlock(&TASK->udebug.lock);
         
@@ -239 +239 @@
  *
  */
-int udebug_set_evmask(udebug_evmask_t mask)
+errno_t udebug_set_evmask(udebug_evmask_t mask)
 {
         LOG("mask = 0x%x", mask);
@@ -266 +266 @@
  *
  */
-int udebug_go(thread_t *thread, call_t *call)
+errno_t udebug_go(thread_t *thread, call_t *call)
 {
         /* On success, this will lock thread->udebug.lock. */
-        int rc = _thread_op_begin(thread, false);
+        errno_t rc = _thread_op_begin(thread, false);
         if (rc != EOK)
                 return rc;
@@ -297 +297 @@
  *
  */
-int udebug_stop(thread_t *thread, call_t *call)
+errno_t udebug_stop(thread_t *thread, call_t *call)
 {
         LOG("udebug_stop()");
@@ -306 +306 @@
          *
          */
-        int rc = _thread_op_begin(thread, true);
+        errno_t rc = _thread_op_begin(thread, true);
         if (rc != EOK)
                 return rc;
@@ -364 +364 @@
  *
  */
-int udebug_thread_read(void **buffer, size_t buf_size, size_t *stored,
+errno_t udebug_thread_read(void **buffer, size_t buf_size, size_t *stored,
     size_t *needed)
 {
@@ -428 +428 @@
  *
  */
-int udebug_name_read(char **data, size_t *data_size)
+errno_t udebug_name_read(char **data, size_t *data_size)
 {
         size_t name_size = str_size(TASK->name) + 1;
@@ -457 +457 @@
  *
  */
-int udebug_args_read(thread_t *thread, void **buffer)
+errno_t udebug_args_read(thread_t *thread, void **buffer)
 {
         /* On success, this will lock t->udebug.lock. */
-        int rc = _thread_op_begin(thread, false);
+        errno_t rc = _thread_op_begin(thread, false);
         if (rc != EOK)
                 return rc;
@@ -500 +500 @@
  *
  */
-int udebug_regs_read(thread_t *thread, void **buffer)
+errno_t udebug_regs_read(thread_t *thread, void **buffer)
 {
         /* On success, this will lock t->udebug.lock */
-        int rc = _thread_op_begin(thread, false);
+        errno_t rc = _thread_op_begin(thread, false);
         if (rc != EOK)
                 return rc;
@@ -536 +536 @@
  *
  */
-int udebug_mem_read(sysarg_t uspace_addr, size_t n, void **buffer)
+errno_t udebug_mem_read(sysarg_t uspace_addr, size_t n, void **buffer)
 {
         /* Verify task state */
@@ -553 +553 @@
          *
          */
-        int rc = copy_from_uspace(data_buffer, (void *) uspace_addr, n);
+        errno_t rc = copy_from_uspace(data_buffer, (void *) uspace_addr, n);
         mutex_unlock(&TASK->udebug.lock);