Changeset b7fd2a0 in mainline for kernel/generic/src/lib

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

kernel/generic/src/lib

Files:

• str.c (modified) (4 diffs)
• str_error.c (modified) (1 diff)

kernel/generic/src/lib/str.c

@@ -217 +217 @@
  *         code was invalid.
  */
-int chr_encode(const wchar_t ch, char *str, size_t *offset, size_t size)
+errno_t chr_encode(const wchar_t ch, char *str, size_t *offset, size_t size)
 {
         if (*offset >= size)
@@ -794 +794 @@
  *
  */
-static int str_uint(const char *nptr, char **endptr, unsigned int base,
+static errno_t str_uint(const char *nptr, char **endptr, unsigned int base,
     bool *neg, uint64_t *result)
 {
@@ -915 +915 @@
  *
  */
-int str_uint64_t(const char *nptr, char **endptr, unsigned int base,
+errno_t str_uint64_t(const char *nptr, char **endptr, unsigned int base,
     bool strict, uint64_t *result)
 {
@@ -922 +922 @@
         bool neg;
         char *lendptr;
-        int ret = str_uint(nptr, &lendptr, base, &neg, result);
+        errno_t ret = str_uint(nptr, &lendptr, base, &neg, result);
         
         if (endptr != NULL)

kernel/generic/src/lib/str_error.c

@@ -40 +40 @@
 #define __errno_entry(name, num, desc) name,
 
-static const int err_num[] = {
+static const errno_t err_num[] = {
 #include <abi/errno.in>
 };