Changeset b7fd2a0 in mainline for kernel/generic/include/proc

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

kernel/generic/include/proc

Files:

• program.h (modified) (1 diff)
• task.h (modified) (3 diffs)
• thread.h (modified) (2 diffs)

kernel/generic/include/proc/program.h

@@ -55 +55 @@
 extern void *program_loader;
 
-extern int program_create(as_t *, uintptr_t, char *, program_t *);
-extern int program_create_from_image(void *, char *, program_t *);
-extern int program_create_loader(program_t *, char *);
+extern errno_t program_create(as_t *, uintptr_t, char *, program_t *);
+extern errno_t program_create_from_image(void *, char *, program_t *);
+extern errno_t program_create_loader(program_t *, char *);
 extern void program_ready(program_t *);
 
-extern sysarg_t sys_program_spawn_loader(char *, size_t);
+extern sys_errno_t sys_program_spawn_loader(char *, size_t);
 
 #endif

kernel/generic/include/proc/task.h

@@ -157 +157 @@
 extern void task_release(task_t *);
 extern task_t *task_find_by_id(task_id_t);
-extern int task_kill(task_id_t);
+extern errno_t task_kill(task_id_t);
 extern void task_kill_self(bool) __attribute__((noreturn));
 extern void task_get_accounting(task_t *, uint64_t *, uint64_t *);
@@ -174 +174 @@
 
 #ifdef __32_BITS__
-extern sysarg_t sys_task_get_id(sysarg64_t *);
+extern sys_errno_t sys_task_get_id(sysarg64_t *);
 #endif
 
@@ -181 +181 @@
 #endif
 
-extern sysarg_t sys_task_set_name(const char *, size_t);
-extern sysarg_t sys_task_kill(task_id_t *);
-extern sysarg_t sys_task_exit(sysarg_t);
+extern sys_errno_t sys_task_set_name(const char *, size_t);
+extern sys_errno_t sys_task_kill(task_id_t *);
+extern sys_errno_t sys_task_exit(sysarg_t);
 
 #endif

kernel/generic/include/proc/thread.h

@@ -256 +256 @@
         thread_join_timeout((t), SYNCH_NO_TIMEOUT, SYNCH_FLAGS_NONE)
 
-extern int thread_join_timeout(thread_t *, uint32_t, unsigned int);
+extern errno_t thread_join_timeout(thread_t *, uint32_t, unsigned int);
 extern void thread_detach(thread_t *);
 
@@ -276 +276 @@
 
 /* Thread syscall prototypes. */
-extern sysarg_t sys_thread_create(uspace_arg_t *, char *, size_t,
+extern sys_errno_t sys_thread_create(uspace_arg_t *, char *, size_t,
     thread_id_t *);
-extern sysarg_t sys_thread_exit(int);
-extern sysarg_t sys_thread_get_id(thread_id_t *);
-extern sysarg_t sys_thread_usleep(uint32_t);
-extern sysarg_t sys_thread_udelay(uint32_t);
+extern sys_errno_t sys_thread_exit(int);
+extern sys_errno_t sys_thread_get_id(thread_id_t *);
+extern sys_errno_t sys_thread_usleep(uint32_t);
+extern sys_errno_t sys_thread_udelay(uint32_t);
 
 #endif