Changeset b7fd2a0 in mainline for kernel/generic/include/mm

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

kernel/generic/include/mm

Files:

• as.h (modified) (4 diffs)
• page.h (modified) (1 diff)
• slab.h (modified) (2 diffs)

kernel/generic/include/mm/as.h

@@ -268 +268 @@
 extern as_area_t *as_area_create(as_t *, unsigned int, size_t, unsigned int,
     mem_backend_t *, mem_backend_data_t *, uintptr_t *, uintptr_t);
-extern int as_area_destroy(as_t *, uintptr_t);
-extern int as_area_resize(as_t *, uintptr_t, size_t, unsigned int);
-extern int as_area_share(as_t *, uintptr_t, size_t, as_t *, unsigned int,
+extern errno_t as_area_destroy(as_t *, uintptr_t);
+extern errno_t as_area_resize(as_t *, uintptr_t, size_t, unsigned int);
+extern errno_t as_area_share(as_t *, uintptr_t, size_t, as_t *, unsigned int,
     uintptr_t *, uintptr_t);
-extern int as_area_change_flags(as_t *, unsigned int, uintptr_t);
+extern errno_t as_area_change_flags(as_t *, unsigned int, uintptr_t);
 
 extern unsigned int as_area_get_flags(as_area_t *);
@@ -283 +283 @@
 
 #ifndef as_constructor_arch
-extern int as_constructor_arch(as_t *, unsigned int);
+extern errno_t as_constructor_arch(as_t *, unsigned int);
 #endif /* !def as_constructor_arch */
 
@@ -291 +291 @@
 
 #ifndef as_create_arch
-extern int as_create_arch(as_t *, unsigned int);
+extern errno_t as_create_arch(as_t *, unsigned int);
 #endif /* !def as_create_arch */
 
@@ -311 +311 @@
 extern sysarg_t sys_as_area_create(uintptr_t, size_t, unsigned int, uintptr_t,
     as_area_pager_info_t *);
-extern sysarg_t sys_as_area_resize(uintptr_t, size_t, unsigned int);
-extern sysarg_t sys_as_area_change_flags(uintptr_t, unsigned int);
-extern sysarg_t sys_as_area_destroy(uintptr_t);
+extern sys_errno_t sys_as_area_resize(uintptr_t, size_t, unsigned int);
+extern sys_errno_t sys_as_area_change_flags(uintptr_t, unsigned int);
+extern sys_errno_t sys_as_area_destroy(uintptr_t);
 
 /* Introspection functions. */

kernel/generic/include/mm/page.h

@@ -67 +67 @@
 extern void page_table_destroy(pte_t *);
 
-extern int page_find_mapping(uintptr_t, uintptr_t *);
-extern sysarg_t sys_page_find_mapping(uintptr_t, uintptr_t *);
+extern errno_t page_find_mapping(uintptr_t, uintptr_t *);
+extern sys_errno_t sys_page_find_mapping(uintptr_t, uintptr_t *);
 
 #endif

kernel/generic/include/mm/slab.h

@@ -94 +94 @@
         size_t size;
         
-        int (*constructor)(void *obj, unsigned int kmflag);
+        errno_t (*constructor)(void *obj, unsigned int kmflag);
         size_t (*destructor)(void *obj);
         
@@ -124 +124 @@
 
 extern slab_cache_t *slab_cache_create(const char *, size_t, size_t,
-    int (*)(void *, unsigned int), size_t (*)(void *), unsigned int);
+    errno_t (*)(void *, unsigned int), size_t (*)(void *), unsigned int);
 extern void slab_cache_destroy(slab_cache_t *);