Changeset b7fd2a0 in mainline for kernel/generic/include/ipc


Ignore:
Timestamp:
2018-01-13T03:10:29Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:
kernel/generic/include/ipc
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • kernel/generic/include/ipc/event.h

    r36f0738 rb7fd2a0  
    9595        event_task_notify((t), (e), (m), (a1), (a2), (a3), (a4), (a5))
    9696
    97 extern int event_notify(event_type_t, bool, sysarg_t, sysarg_t, sysarg_t,
     97extern errno_t event_notify(event_type_t, bool, sysarg_t, sysarg_t, sysarg_t,
    9898    sysarg_t, sysarg_t);
    99 extern int event_task_notify(struct task *, event_task_type_t, bool, sysarg_t, sysarg_t,
     99extern errno_t event_task_notify(struct task *, event_task_type_t, bool, sysarg_t, sysarg_t,
    100100    sysarg_t, sysarg_t, sysarg_t);
    101101
    102 extern sysarg_t sys_ipc_event_subscribe(sysarg_t, sysarg_t);
    103 extern sysarg_t sys_ipc_event_unsubscribe(sysarg_t);
    104 extern sysarg_t sys_ipc_event_unmask(sysarg_t);
     102extern sys_errno_t sys_ipc_event_subscribe(sysarg_t, sysarg_t);
     103extern sys_errno_t sys_ipc_event_unsubscribe(sysarg_t);
     104extern sys_errno_t sys_ipc_event_unmask(sysarg_t);
    105105
    106106#endif

  • kernel/generic/include/ipc/ipc.h

    r36f0738 rb7fd2a0  
    186186extern void ipc_call_release(call_t *);
    187187
    188 extern int ipc_call_sync(phone_t *, call_t *);
    189 extern int ipc_call(phone_t *, call_t *);
     188extern errno_t ipc_call_sync(phone_t *, call_t *);
     189extern errno_t ipc_call(phone_t *, call_t *);
    190190extern call_t *ipc_wait_for_call(answerbox_t *, uint32_t, unsigned int);
    191 extern int ipc_forward(call_t *, phone_t *, answerbox_t *, unsigned int);
     191extern errno_t ipc_forward(call_t *, phone_t *, answerbox_t *, unsigned int);
    192192extern void ipc_answer(answerbox_t *, call_t *);
    193193extern void _ipc_answer_free_call(call_t *, bool);
    … …  
    195195extern void ipc_phone_init(phone_t *, struct task *);
    196196extern bool ipc_phone_connect(phone_t *, answerbox_t *);
    197 extern int ipc_phone_hangup(phone_t *);
     197extern errno_t ipc_phone_hangup(phone_t *);
    198198
    199199extern void ipc_answerbox_init(answerbox_t *, struct task *);
    200200
    201201extern void ipc_cleanup(void);
    202 extern void ipc_backsend_err(phone_t *, call_t *, int);
     202extern void ipc_backsend_err(phone_t *, call_t *, errno_t);
    203203extern void ipc_answerbox_slam_phones(answerbox_t *, bool);
    204204extern void ipc_cleanup_call_list(answerbox_t *, list_t *);

  • kernel/generic/include/ipc/ipcrsc.h

    r36f0738 rb7fd2a0  
    4040#include <cap/cap.h>
    4141
    42 extern int phone_alloc(task_t *, cap_handle_t *);
     42extern errno_t phone_alloc(task_t *, cap_handle_t *);
    4343extern bool phone_connect(cap_handle_t, answerbox_t *);
    4444extern void phone_dealloc(cap_handle_t);

  • kernel/generic/include/ipc/irq.h

    r36f0738 rb7fd2a0  
    5151extern void ipc_irq_top_half_handler(irq_t *);
    5252
    53 extern int ipc_irq_subscribe(answerbox_t *, inr_t, sysarg_t, irq_code_t *,
     53extern errno_t ipc_irq_subscribe(answerbox_t *, inr_t, sysarg_t, irq_code_t *,
    5454    cap_handle_t *);
    55 extern int ipc_irq_unsubscribe(answerbox_t *, int);
     55extern errno_t ipc_irq_unsubscribe(answerbox_t *, int);
    5656
    5757/*

  • kernel/generic/include/ipc/kbox.h

    r36f0738 rb7fd2a0  
    5050} kbox_t;
    5151
    52 extern int ipc_connect_kbox(task_id_t, cap_handle_t *);
     52extern errno_t ipc_connect_kbox(task_id_t, cap_handle_t *);
    5353extern void ipc_kbox_cleanup(void);
    5454

  • kernel/generic/include/ipc/sysipc.h

    r36f0738 rb7fd2a0  
    4040#include <typedefs.h>
    4141
    42 extern int ipc_req_internal(int, ipc_data_t *, sysarg_t);
     42extern errno_t ipc_req_internal(int, ipc_data_t *, sysarg_t);
    4343
    44 extern sysarg_t sys_ipc_call_async_fast(sysarg_t, sysarg_t, sysarg_t,
     44extern sys_errno_t sys_ipc_call_async_fast(sysarg_t, sysarg_t, sysarg_t,
    4545    sysarg_t, sysarg_t, sysarg_t);
    46 extern sysarg_t sys_ipc_call_async_slow(sysarg_t, ipc_data_t *, sysarg_t);
    47 extern sysarg_t sys_ipc_answer_fast(sysarg_t, sysarg_t, sysarg_t, sysarg_t,
     46extern sys_errno_t sys_ipc_call_async_slow(sysarg_t, ipc_data_t *, sysarg_t);
     47extern sys_errno_t sys_ipc_answer_fast(sysarg_t, sysarg_t, sysarg_t, sysarg_t,
    4848    sysarg_t, sysarg_t);
    49 extern sysarg_t sys_ipc_answer_slow(sysarg_t, ipc_data_t *);
    50 extern sysarg_t sys_ipc_wait_for_call(ipc_data_t *, uint32_t, unsigned int);
    51 extern sysarg_t sys_ipc_poke(void);
    52 extern sysarg_t sys_ipc_forward_fast(sysarg_t, sysarg_t, sysarg_t, sysarg_t,
     49extern sys_errno_t sys_ipc_answer_slow(sysarg_t, ipc_data_t *);
     50extern sys_errno_t sys_ipc_wait_for_call(ipc_data_t *, uint32_t, unsigned int);
     51extern sys_errno_t sys_ipc_poke(void);
     52extern sys_errno_t sys_ipc_forward_fast(sysarg_t, sysarg_t, sysarg_t, sysarg_t,
    5353    sysarg_t, unsigned int);
    54 extern sysarg_t sys_ipc_forward_slow(sysarg_t, sysarg_t, ipc_data_t *,
     54extern sys_errno_t sys_ipc_forward_slow(sysarg_t, sysarg_t, ipc_data_t *,
    5555    unsigned int);
    56 extern sysarg_t sys_ipc_hangup(sysarg_t);
     56extern sys_errno_t sys_ipc_hangup(sysarg_t);
    5757
    58 extern sysarg_t sys_ipc_irq_subscribe(inr_t, sysarg_t, irq_code_t *, cap_handle_t *);
    59 extern sysarg_t sys_ipc_irq_unsubscribe(sysarg_t);
     58extern sys_errno_t sys_ipc_irq_subscribe(inr_t, sysarg_t, irq_code_t *, cap_handle_t *);
     59extern sys_errno_t sys_ipc_irq_unsubscribe(sysarg_t);
    6060
    61 extern sysarg_t sys_ipc_connect_kbox(task_id_t *, cap_handle_t *);
     61extern sys_errno_t sys_ipc_connect_kbox(task_id_t *, cap_handle_t *);
    6262
    6363#endif

  • kernel/generic/include/ipc/sysipc_ops.h

    r36f0738 rb7fd2a0  
    9090         * Invoked on:          all calls
    9191         */
    92         int (* request_preprocess)(call_t *, phone_t *);
     92        errno_t (* request_preprocess)(call_t *, phone_t *);
    9393
    9494        /**
    … …  
    102102         * Invoked on:          all forgotten calls
    103103         */     
    104         int (* request_forget)(call_t *);
     104        errno_t (* request_forget)(call_t *);
    105105
    106106        /**
    … …  
    123123         * Invoked on:          all forgotten calls
    124124         */
    125         int (* answer_cleanup)(call_t *, ipc_data_t *);
     125        errno_t (* answer_cleanup)(call_t *, ipc_data_t *);
    126126
    127127        /**
    … …  
    134134         * Invoked on:          all answered calls
    135135         */
    136         int (* answer_preprocess)(call_t *, ipc_data_t *);
     136        errno_t (* answer_preprocess)(call_t *, ipc_data_t *);
    137137
    138138        /**
    … …  
    144144         * Invoked on:          all answered calls
    145145         */
    146         int (* answer_process)(call_t *);
     146        errno_t (* answer_process)(call_t *);
    147147} sysipc_ops_t;
    148148
    149149extern sysipc_ops_t *sysipc_ops_get(sysarg_t);
    150150
    151 extern int null_request_preprocess(call_t *, phone_t *);
    152 extern int null_request_forget(call_t *);
     151extern errno_t null_request_preprocess(call_t *, phone_t *);
     152extern errno_t null_request_forget(call_t *);
    153153extern int null_request_process(call_t *, answerbox_t *);
    154 extern int null_answer_cleanup(call_t *, ipc_data_t *);
    155 extern int null_answer_preprocess(call_t *, ipc_data_t *);
    156 extern int null_answer_process(call_t *);
     154extern errno_t null_answer_cleanup(call_t *, ipc_data_t *);
     155extern errno_t null_answer_preprocess(call_t *, ipc_data_t *);
     156extern errno_t null_answer_process(call_t *);
    157157
    158158#endif

  • kernel/generic/include/ipc/sysipc_priv.h

    r36f0738 rb7fd2a0  
    3838#include <ipc/ipc.h>
    3939
    40 extern int answer_preprocess(call_t *, ipc_data_t *);
     40extern errno_t answer_preprocess(call_t *, ipc_data_t *);
    4141
    4242#endif
Note: See TracChangeset for help on using the changeset viewer.