Changeset b7fd2a0 in mainline for kernel/arch

Timestamp:

2018-01-13T03:10:29Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

Location:

kernel/arch

Files:

• abs32le/src/abs32le.c (modified) (1 diff)
• arm32/src/mach/beaglebone/beaglebone.c (modified) (1 diff)
• ia64/src/ddi/ddi.c (modified) (2 diffs)
• riscv64/src/riscv64.c (modified) (1 diff)
• sparc64/src/mm/sun4u/as.c (modified) (2 diffs)
• sparc64/src/mm/sun4v/as.c (modified) (2 diffs)

kernel/arch/abs32le/src/abs32le.c

@@ -125 +125 @@
 }
 
-int memcpy_from_uspace(void *dst, const void *uspace_src, size_t size)
+errno_t memcpy_from_uspace(void *dst, const void *uspace_src, size_t size)
 {
         return EOK;
 }
 
-int memcpy_to_uspace(void *uspace_dst, const void *src, size_t size)
+errno_t memcpy_to_uspace(void *uspace_dst, const void *src, size_t size)
 {
         return EOK;

kernel/arch/arm32/src/mach/beaglebone/beaglebone.c

@@ -123 +123 @@
 {
         unsigned sysclk_freq;
-        int rc;
+        errno_t rc;
 
         /* Initialize the IRQ */

kernel/arch/ia64/src/ddi/ddi.c

@@ -53 +53 @@
  * @return EOK on success or an error code from errno.h.
  */
-int ddi_iospace_enable_arch(task_t *task, uintptr_t ioaddr, size_t size)
+errno_t ddi_iospace_enable_arch(task_t *task, uintptr_t ioaddr, size_t size)
 {
         if (!task->arch.iomap) {
@@ -85 +85 @@
  * @return EOK on success or an error code from errno.h.
  */
-int ddi_iospace_disable_arch(task_t *task, uintptr_t ioaddr, size_t size)
+errno_t ddi_iospace_disable_arch(task_t *task, uintptr_t ioaddr, size_t size)
 {
         if (!task->arch.iomap)

kernel/arch/riscv64/src/riscv64.c

@@ -143 +143 @@
 }
 
-int memcpy_from_uspace(void *dst, const void *uspace_src, size_t size)
+errno_t memcpy_from_uspace(void *dst, const void *uspace_src, size_t size)
 {
         return EOK;
 }
 
-int memcpy_to_uspace(void *uspace_dst, const void *src, size_t size)
+errno_t memcpy_to_uspace(void *uspace_dst, const void *src, size_t size)
 {
         return EOK;

kernel/arch/sparc64/src/mm/sun4u/as.c

@@ -60 +60 @@
 }
 
-int as_constructor_arch(as_t *as, unsigned int flags)
+errno_t as_constructor_arch(as_t *as, unsigned int flags)
 {
 #ifdef CONFIG_TSB
@@ -88 +88 @@
 }
 
-int as_create_arch(as_t *as, unsigned int flags)
+errno_t as_create_arch(as_t *as, unsigned int flags)
 {
 #ifdef CONFIG_TSB

kernel/arch/sparc64/src/mm/sun4v/as.c

@@ -63 +63 @@
 }
 
-int as_constructor_arch(as_t *as, unsigned int flags)
+errno_t as_constructor_arch(as_t *as, unsigned int flags)
 {
 #ifdef CONFIG_TSB
@@ -97 +97 @@
 }
 
-int as_create_arch(as_t *as, unsigned int flags)
+errno_t as_create_arch(as_t *as, unsigned int flags)
 {
 #ifdef CONFIG_TSB