Changeset b5f716b in mainline for uspace/srv/net/dnsrsrv

Timestamp:

2014-04-18T11:32:09Z (11 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

5792d6e

Parents:

80f6be9

Message:

Unbreak optimized-for-size builds (fix maybe-uninitialized)

When possible, converted the maybe-unitialized (in all cases, false alarms)
variables to an assignment with assertion testing that reasonable value
was added.

Location:

uspace/srv/net/dnsrsrv

Files:

• dns_msg.c (modified) (3 diffs)
• transport.c (modified) (2 diffs)

uspace/srv/net/dnsrsrv/dns_msg.c

@@ -487 +487 @@
         size_t size;
         dns_header_t hdr;
-        size_t q_size;
+        size_t q_size = 0;
         size_t di;
         int rc;
@@ -515 +515 @@
                         return rc;
 
+                assert(q_size > 0);
+
                 size += q_size;
         }
@@ -532 +534 @@
                         return rc;
                 }
+
+                assert(q_size > 0);
 
                 di += q_size;

uspace/srv/net/dnsrsrv/transport.c

@@ -286 +286 @@
 static int transport_recv_fibril(void *arg)
 {
-        dns_message_t *resp;
+        dns_message_t *resp = NULL;
         trans_req_t *treq;
         int rc;
@@ -294 +294 @@
                 if (rc != EOK)
                         continue;
+
+                assert(resp != NULL);
 
                 fibril_mutex_lock(&treq_lock);