Changeset b3c39690 in mainline for uspace/lib/usbdev/src

Timestamp:

2018-01-21T23:19:20Z (7 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

db51a6a6

Parents:

09187c6e

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-21 23:19:14)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-21 23:19:20)

Message:

usb: remove misleading usb_device_get_mapped_ep

Even though this method may seem very convenient to use, it's actually
wrong. The devices are usually not required to have strict endpoint
numbers. That's why the mapping mechanism exists. Therefore, it's just
not possible to rely on fixed endpoint mapping.

There could be similar method, that would take the transfer type and
direction, but it's much better to ask for the complete mapping then.

File:

• uspace/lib/usbdev/src/devdrv.c (modified) (1 diff)

uspace/lib/usbdev/src/devdrv.c

@@ -341 +341 @@
 }
 
-usb_endpoint_mapping_t * usb_device_get_mapped_ep(
-    usb_device_t *usb_dev, usb_endpoint_t ep)
-{
-        assert(usb_dev);
-        for (unsigned i = 0; i < usb_dev->pipes_count; ++i) {
-                if (usb_dev->pipes[i].pipe.desc.endpoint_no == ep)
-                        return &usb_dev->pipes[i];
-        }
-        return NULL;
-}
-
 int usb_device_unmap_ep(usb_endpoint_mapping_t *epm)
 {