Changeset abf6c01 in mainline for kernel/generic/src/proc

Timestamp:

2018-11-09T22:03:24Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

436a0a5

Parents:

ba9a150

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-11-08 17:00:46)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-11-09 22:03:24)

Message:

Add FRAME_ATOMIC to some allocations

Location:

kernel/generic/src/proc

Files:

• task.c (modified) (1 diff)
• thread.c (modified) (3 diffs)

kernel/generic/src/proc/task.c

@@ -199 +199 @@
 task_t *task_create(as_t *as, const char *name)
 {
-        task_t *task = (task_t *) slab_alloc(task_cache, 0);
-        if (task == NULL) {
+        task_t *task = (task_t *) slab_alloc(task_cache, FRAME_ATOMIC);
+        if (!task)
                 return NULL;
-        }
 
         task_create_arch(task);

kernel/generic/src/proc/thread.c

@@ -165 +165 @@
 
 #ifdef CONFIG_FPU
-        thread->saved_fpu_context = slab_alloc(fpu_context_cache, kmflags);
+        thread->saved_fpu_context = slab_alloc(fpu_context_cache,
+            FRAME_ATOMIC | kmflags);
         if (!thread->saved_fpu_context)
                 return ENOMEM;
@@ -338 +339 @@
     thread_flags_t flags, const char *name)
 {
-        thread_t *thread = (thread_t *) slab_alloc(thread_cache, 0);
+        thread_t *thread = (thread_t *) slab_alloc(thread_cache, FRAME_ATOMIC);
         if (!thread)
                 return NULL;
@@ -652 +653 @@
 
         return waitq_sleep_timeout(&thread->join_wq, usec, flags, NULL);
+
+        // FIXME: join should deallocate the thread.
+        //        Current code calls detach after join, that's contrary to how
+        //        join is used in other threading APIs.
 }