Changeset a46e56b in mainline for uspace/drv/hid/xtkbd

Timestamp:

2018-03-22T06:49:35Z (8 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

77f0a1d

Parents:

3e242d2

git-author:

Jakub Jermar <jakub@…> (2018-03-21 23:29:06)

git-committer:

Jakub Jermar <jakub@…> (2018-03-22 06:49:35)

Message:

Prefer handle over ID in naming handle variables

File:

• uspace/drv/hid/xtkbd/xtkbd.c (modified) (5 diffs)

uspace/drv/hid/xtkbd/xtkbd.c

@@ -329 +329 @@
  *
  * @param fun     Device function handling the call.
- * @param icallid Call id.
+ * @param icall_handle Call id.
  * @param icall   Call data.
  *
  */
 static void default_connection_handler(ddf_fun_t *fun,
-    cap_call_handle_t icallid, ipc_call_t *icall)
+    cap_call_handle_t icall_handle, ipc_call_t *icall)
 {
         const sysarg_t method = IPC_GET_IMETHOD(*icall);
@@ -357 +357 @@
                 errno_t rc = chardev_write(kbd->chardev, &cmds[0], 1, &nwr);
                 if (rc != EOK) {
-                        async_answer_0(icallid, rc);
+                        async_answer_0(icall_handle, rc);
                         break;
                 }
 
                 rc = chardev_write(kbd->chardev, &cmds[1], 1, &nwr);
-                async_answer_0(icallid, rc);
+                async_answer_0(icall_handle, rc);
                 break;
         /*
@@ -375 +375 @@
                         ddf_msg(LVL_WARN,
                             "Failed creating callback session");
-                        async_answer_0(icallid, EAGAIN);
+                        async_answer_0(icall_handle, EAGAIN);
                         break;
                 }
@@ -382 +382 @@
                         kbd->client_sess = sess;
                         ddf_msg(LVL_DEBUG, "Set client session");
-                        async_answer_0(icallid, EOK);
+                        async_answer_0(icall_handle, EOK);
                 } else {
                         ddf_msg(LVL_ERROR, "Client session already set");
-                        async_answer_0(icallid, ELIMIT);
+                        async_answer_0(icall_handle, ELIMIT);
                 }
 
@@ -391 +391 @@
         default:
                 ddf_msg(LVL_ERROR, "Unknown method: %d.", (int)method);
-                async_answer_0(icallid, EINVAL);
+                async_answer_0(icall_handle, EINVAL);
                 break;
         }