Changeset a36c4aa in mainline for uspace/drv

Timestamp:

2025-08-12T18:03:48Z (6 months ago)

Author:

Martin Decky <martin@…>

Branches:

master

Children:

113fb4f

Parents:

2e9f284

Message:

Switch to binutils 2.45 and GCC 15.2

This requires a few minor modifications and one temporary workaround,
but should be otherwise painless.

The switch to binutils 2.45 is especially useful due to its fixes when
compiled by a C23 compiler.

Location:

uspace/drv/bus/usb

Files:

• vhc/conndev.c (modified) (1 diff)
• xhci/hc.c (modified) (1 diff)
• xhci/hw_struct/regs.h (modified) (1 diff)
• xhci/rh.h (modified) (1 diff)

uspace/drv/bus/usb/vhc/conndev.c

@@ -43 +43 @@
 #include "vhcd.h"
 
+#define PLUGGED_DEVICE_NAME_MAXLEN 256
+
 static fibril_local uintptr_t plugged_device_handle = 0;
-#define PLUGGED_DEVICE_NAME_MAXLEN 256
-static fibril_local char plugged_device_name[PLUGGED_DEVICE_NAME_MAXLEN + 1] = "<unknown>";
+
+/*
+ * The explicit "initial-exec" TLS model attribute is a temporary workaround
+ * for a bug in GCC (observed in 14.2 and 15.2) that manifests in combination
+ * with the binutils 2.45 linker on MIPS.
+ *
+ * Without the attribute, the linker reports the following error:
+ *
+ *  can't find matching LO16 reloc against `plugged_device_name' for
+ *  R_MIPS_TLS_TPREL_HI16 at 0x238 in section
+ *  `.text.default_connection_handler'
+ *
+ * The immediate cause is a missing R_MIPS_TLS_TPREL_LO16 relocation that
+ * matches the R_MIPS_TLS_TPREL_HI16 relocation. The root cause is probably
+ * an aggressive optimization in the compiler that removes the relocation
+ * despite being needed.
+ */
+static fibril_local char plugged_device_name[PLUGGED_DEVICE_NAME_MAXLEN + 1]
+    __attribute__((tls_model("initial-exec"))) = "<unknown>";
 
 /** Receive device name.

uspace/drv/bus/usb/xhci/hc.c

@@ -166 +166 @@
                                         speeds[psiv].major = major;
                                         speeds[psiv].minor = minor;
-                                        str_ncpy(speeds[psiv].name, 4, name.str, 4);
+                                        memcpy(speeds[psiv].name, name.str, 4);
                                         speeds[psiv].usb_speed = USB_SPEED_MAX;
 

uspace/drv/bus/usb/xhci/hw_struct/regs.h

@@ -551 +551 @@
 
 typedef union {
-        char str [4];
+        char str[4] __attribute__((nonstring));
         uint32_t packed;
 } xhci_sp_name_t;

uspace/drv/bus/usb/xhci/rh.h

@@ -51 +51 @@
  */
 typedef struct xhci_port_speed {
-        char name [4];
+        char name[4] __attribute__((nonstring));
         uint8_t major, minor;
         uint64_t rx_bps, tx_bps;