Changeset a35b458 in mainline for uspace/lib/c/arch/amd64

Timestamp:

2018-03-02T20:10:49Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f1380b7

Parents:

3061bc1

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)

Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

Location:

uspace/lib/c/arch/amd64

Files:

• include/libarch/atomic.h (modified) (4 diffs)
• src/entry.S (modified) (1 diff)
• src/entryjmp.S (modified) (1 diff)
• src/fibril.S (modified) (3 diffs)
• src/syscall.S (modified) (1 diff)
• src/thread_entry.S (modified) (1 diff)

uspace/lib/c/arch/amd64/include/libarch/atomic.h

@@ -75 +75 @@
 {
         atomic_count_t r = 1;
-        
+
 #ifdef __PCC__
         asm volatile (
@@ -89 +89 @@
         );
 #endif
-        
+
         return r;
 }
@@ -96 +96 @@
 {
         atomic_count_t r = -1;
-        
+
 #ifdef __PCC__
         asm volatile (
@@ -110 +110 @@
         );
 #endif
-        
+
         return r;
 }

uspace/lib/c/arch/amd64/src/entry.S

@@ -44 +44 @@
         pushq $0
         movq %rsp, %rbp
-        
+
         # %rdi was deliberately chosen as the first argument is also in %rdi
         # Pass PCB pointer to __main (no operation)

uspace/lib/c/arch/amd64/src/entryjmp.S

@@ -39 +39 @@
         push %rbp
         movq %rsp, %rbp
-        
+
         # pcb must be passed in %rdi, use %rdx as a scratch register
         mov %rdi, %rdx
         mov %rsi, %rdi
-        
+
         # jump to entry point
         jmp *%rdx

uspace/lib/c/arch/amd64/src/fibril.S

@@ -39 +39 @@
 FUNCTION_BEGIN(context_save)
         movq (%rsp), %rdx     # the caller's return %eip
-        
+
         # in %rdi is passed 1st argument
         movq %rdx, CONTEXT_OFFSET_PC(%rdi)
         movq %rsp, CONTEXT_OFFSET_SP(%rdi)
-        
+
         movq %rbx, CONTEXT_OFFSET_RBX(%rdi)
         movq %rbp, CONTEXT_OFFSET_RBP(%rdi)
@@ -50 +50 @@
         movq %r14, CONTEXT_OFFSET_R14(%rdi)
         movq %r15, CONTEXT_OFFSET_R15(%rdi)
-        
+
         movq %fs:0, %rax
         movq %rax, CONTEXT_OFFSET_TLS(%rdi)
-        
+
         xorl %eax, %eax                      # context_save returns 1
         incl %eax
@@ -71 +71 @@
         movq CONTEXT_OFFSET_RBP(%rdi), %rbp
         movq CONTEXT_OFFSET_RBX(%rdi), %rbx
-        
+
         movq CONTEXT_OFFSET_SP(%rdi), %rsp   # ctx->sp -> %rsp
-        
+
         movq CONTEXT_OFFSET_PC(%rdi), %rdx
-        
+
         movq %rdx,(%rsp)
-        
+
         movq CONTEXT_OFFSET_TLS(%rdi), %rdi
         movq %rdi, %fs:0
-        
+
         xorl %eax, %eax                      # context_restore returns 0
         ret

uspace/lib/c/arch/amd64/src/syscall.S

@@ -30 +30 @@
 
 .text
-        
+
 ## Make a system call.
 #

uspace/lib/c/arch/amd64/src/thread_entry.S

@@ -41 +41 @@
         pushq $0
         movq %rsp, %rbp
-        
+
         #
         # RAX contains address of uarg