Changeset a35b458 in mainline for uspace/drv/intctl

Timestamp:

2018-03-02T20:10:49Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f1380b7

Parents:

3061bc1

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)

Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

Location:

uspace/drv/intctl

Files:

• apic/apic.c (modified) (3 diffs)
• i8259/i8259.c (modified) (9 diffs)

uspace/drv/intctl/apic/apic.c

@@ -169 +169 @@
         ipc_call_t call;
         apic_t *apic;
-        
+
         /*
          * Answer the first IPC_M_CONNECT_ME_TO call.
          */
         async_answer_0(iid, EOK);
-        
+
         apic = (apic_t *)ddf_dev_data_get(ddf_fun_get_dev((ddf_fun_t *)arg));
-        
+
         while (true) {
                 callid = async_get_call(&call);
-                
+
                 if (!IPC_GET_IMETHOD(call)) {
                         /* The other side has hung up. */
@@ -185 +185 @@
                         return;
                 }
-                
+
                 switch (IPC_GET_IMETHOD(call)) {
                 case IRC_ENABLE_INTERRUPT:
@@ -213 +213 @@
         void *regs;
         errno_t rc;
-        
+
         if ((sysinfo_get_value("apic", &have_apic) != EOK) || (!have_apic)) {
                 printf("%s: No APIC found\n", NAME);
                 return ENOTSUP;
         }
-        
+
         rc = pio_enable((void *) res->base, IO_APIC_SIZE, &regs);
         if (rc != EOK) {

uspace/drv/intctl/i8259/i8259.c

@@ -68 +68 @@
         if (irq > PIC_MAX_IRQ)
                 return ENOENT;
-        
+
         uint16_t irqmask = 1 << irq;
         uint8_t val;
-        
+
         if (irqmask & 0xff) {
                 val = pio_read_8(i8259->regs0 + PIC_PIC0PORT2);
@@ -77 +77 @@
                     (uint8_t) (val & (~(irqmask & 0xff))));
         }
-        
+
         if (irqmask >> 8) {
                 val = pio_read_8(i8259->regs1 + PIC_PIC1PORT2);
@@ -83 +83 @@
                     (uint8_t) (val & (~(irqmask >> 8))));
         }
-        
+
         return EOK;
 }
@@ -98 +98 @@
         ipc_call_t call;
         i8259_t *i8259 = NULL /* XXX */;
-        
+
         /*
          * Answer the first IPC_M_CONNECT_ME_TO call.
          */
         async_answer_0(iid, EOK);
-        
+
         i8259 = (i8259_t *)ddf_dev_data_get(ddf_fun_get_dev((ddf_fun_t *)arg));
-        
+
         while (true) {
                 callid = async_get_call(&call);
-                
+
                 if (!IPC_GET_IMETHOD(call)) {
                         /* The other side has hung up. */
@@ -114 +114 @@
                         return;
                 }
-                
+
                 switch (IPC_GET_IMETHOD(call)) {
                 case IRC_ENABLE_INTERRUPT:
@@ -143 +143 @@
         ddf_fun_t *fun_a = NULL;
         errno_t rc;
-        
+
         if ((sysinfo_get_value("i8259", &have_i8259) != EOK) || (!have_i8259)) {
                 printf("%s: No i8259 found\n", NAME);
                 return ENOTSUP;
         }
-        
+
         if ((pio_enable((void *) res->base0, IO_RANGE0_SIZE,
             (void **) &regs0) != EOK) ||
@@ -156 +156 @@
                 return EIO;
         }
-        
+
         i8259->regs0 = regs0;
         i8259->regs1 = regs1;
-        
+
         fun_a = ddf_fun_create(i8259->dev, fun_exposed, "a");
         if (fun_a == NULL) {
@@ -166 +166 @@
                 goto error;
         }
-        
+
         ddf_fun_set_conn_handler(fun_a, i8259_connection);
-        
+
         rc = ddf_fun_bind(fun_a);
         if (rc != EOK) {
@@ -174 +174 @@
                 goto error;
         }
-        
+
         rc = ddf_fun_add_to_category(fun_a, "irc");
         if (rc != EOK)
                 goto error;
-        
+
         return EOK;
 error: