Changeset a35b458 in mainline for uspace/app/getterm

Timestamp:

2018-03-02T20:10:49Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f1380b7

Parents:

3061bc1

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)

Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:

• uspace/app/getterm/getterm.c (modified) (8 diffs)

uspace/app/getterm/getterm.c

@@ -63 +63 @@
         if (fclose(*stream))
                 return;
-        
+
         *stream = NULL;
-        
+
         int oldfd;
         errno_t rc = vfs_lookup_open(path, WALK_REGULAR, mode, &oldfd);
         if (rc != EOK)
                 return;
-        
+
         if (oldfd != fd) {
                 int newfd;
                 if (vfs_clone(oldfd, fd, false, &newfd) != EOK)
                         return;
-                
+
                 assert(newfd == fd);
 
@@ -81 +81 @@
                         return;
         }
-        
+
         *stream = fdopen(fd, fmode);
 }
@@ -93 +93 @@
                 return 1;
         }
-        
+
         char *term = *argv;
         argv++;
         argc--;
-        
+
         char *locfs = *argv;
         argv++;
         argc--;
-        
+
         bool print_msg = false;
         bool wait = false;
-        
+
         while ((argc > 0) && (str_cmp(*argv, "--") != 0)) {
                 if (str_cmp(*argv, "--msg") == 0) {
@@ -114 +114 @@
                         return 2;
                 }
-                
+
                 argv++;
                 argc--;
         }
-        
+
         if (argc < 1) {
                 usage();
                 return 3;
         }
-        
+
         /* Skip "--" */
         argv++;
         argc--;
-        
+
         char *cmd = *argv;
         char **args = argv;
-        
+
         if (wait) {
                 /* Wait for the terminal service to be ready */
@@ -141 +141 @@
                 }
         }
-        
+
         char term_node[LOC_NAME_MAXLEN];
         snprintf(term_node, LOC_NAME_MAXLEN, "%s/%s", locfs, term);
-        
+
         reopen(&stdin, 0, term_node, MODE_READ, "r");
         reopen(&stdout, 1, term_node, MODE_WRITE, "w");
         reopen(&stderr, 2, term_node, MODE_WRITE, "w");
-        
+
         if (stdin == NULL)
                 return 4;
-        
+
         if (stdout == NULL)
                 return 5;
-        
+
         if (stderr == NULL)
                 return 6;
-        
+
         /*
          * FIXME: fdopen() should actually detect that we are opening a console
@@ -163 +163 @@
          */
         setvbuf(stdout, NULL, _IOLBF, BUFSIZ);
-        
+
         version_print(term);
         if (print_msg)
                 welcome_msg_print();
-        
+
         task_id_t id;
         task_wait_t twait;
-        
+
         errno_t rc = task_spawnv(&id, &twait, cmd, (const char * const *) args);
         if (rc != EOK) {
@@ -177 +177 @@
                 return rc;
         }
-        
+
         task_exit_t texit;
         int retval;
@@ -186 +186 @@
                 return rc;
         }
-        
+
         return 0;
 }