Changeset a35b458 in mainline for kernel/test/smpcall

Timestamp:

2018-03-02T20:10:49Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f1380b7

Parents:

3061bc1

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)

Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:

• kernel/test/smpcall/smpcall1.c (modified) (9 diffs)

kernel/test/smpcall/smpcall1.c

@@ -66 +66 @@
         size_t *pcall_cnt = (size_t*)p;
         smp_call_t call_info[MAX_CPUS];
-        
+
         unsigned int cpu_count = min(config.cpu_active, MAX_CPUS);
-        
+
         for (int iter = 0; iter < ITERATIONS; ++iter) {
                 /* Synchronous version. */
@@ -79 +79 @@
                         smp_call(cpu_id, inc, pcall_cnt);
                 }
-                
+
                 /*
                  * Async calls run in parallel on different cpus, so passing the
@@ -85 +85 @@
                  */
                 size_t local_cnt[MAX_CPUS] = {0};
-                
+
                 /* Now start asynchronous calls. */
                 for (unsigned cpu_id = 0; cpu_id < cpu_count; ++cpu_id) {
                         smp_call_async(cpu_id, inc, &local_cnt[cpu_id], &call_info[cpu_id]);
                 }
-                
+
                 /* And wait for all async calls to complete. */
                 for (unsigned cpu_id = 0; cpu_id < cpu_count; ++cpu_id) {
@@ -112 +112 @@
         size_t call_cnt[MAX_CPUS] = {0};
         thread_t *thread[MAX_CPUS] = { NULL };
-        
+
         unsigned int cpu_count = min(config.cpu_active, MAX_CPUS);
         size_t running_thread_cnt = 0;
 
         TPRINTF("Spawning threads on %u cpus.\n", cpu_count);
-        
+
         /* Create a wired thread on each cpu. */
         for (unsigned int id = 0; id < cpu_count; ++id) {
                 thread[id] = thread_create(test_thread, &call_cnt[id], TASK,
                         THREAD_FLAG_NONE, "smp-call-test");
-                
+
                 if (thread[id]) {
                         thread_wire(thread[id], &cpus[id]);
@@ -133 +133 @@
         size_t exp_calls = calc_exp_calls(running_thread_cnt);
         size_t exp_calls_sum = exp_calls * cpu_count;
-        
+
         TPRINTF("Running %zu wired threads. Expecting %zu calls. Be patient.\n",
                 running_thread_cnt, exp_calls_sum);
@@ -142 +142 @@
                 }
         }
-        
+
         /* Wait for threads to complete. */
         for (unsigned int i = 0; i < cpu_count; ++i) {
@@ -152 +152 @@
 
         TPRINTF("Threads finished. Checking number of smp_call()s.\n");
-        
+
         bool ok = true;
         size_t calls_sum = 0;
-        
+
         for (size_t i = 0; i < cpu_count; ++i) {
                 if (thread[i] != NULL) {
@@ -164 +164 @@
                         }
                 }
-                
+
                 calls_sum += call_cnt[i];
         }
-        
+
         if (calls_sum != exp_calls_sum) {
                 TPRINTF("Error: total acknowledged sum: %zu instead of %zu.\n",
                         calls_sum, exp_calls_sum);
-                
+
                 ok = false;
         }
-        
+
         if (ok) {
                 TPRINTF("Success: number of received smp_calls is as expected (%zu).\n",
@@ -181 +181 @@
         } else
                 return "Failed: incorrect acknowledged smp_calls.\n";
-        
+
 }