Changeset a35b458 in mainline for kernel/generic/src/debug/symtab.c

Timestamp:

2018-03-02T20:10:49Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f1380b7

Parents:

3061bc1

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)

Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:

• kernel/generic/src/debug/symtab.c (modified) (10 diffs)

kernel/generic/src/debug/symtab.c

@@ -58 +58 @@
 #ifdef CONFIG_SYMTAB
         size_t i;
-        
+
         for (i = 1; symbol_table[i].address_le; i++) {
                 if (addr < uint64_t_le2host(symbol_table[i].address_le))
                         break;
         }
-        
+
         if (addr >= uint64_t_le2host(symbol_table[i - 1].address_le)) {
                 *name = symbol_table[i - 1].symbol_name;
@@ -71 +71 @@
                 return EOK;
         }
-        
+
         *name = NULL;
         return ENOENT;
-        
+
 #else
         *name = NULL;
@@ -97 +97 @@
         const char *name;
         errno_t rc = symtab_name_lookup(addr, &name, NULL);
-        
+
         switch (rc) {
         case EOK:
@@ -121 +121 @@
 {
         size_t namelen = str_length(name);
-        
+
         size_t pos;
         for (pos = *startpos; symbol_table[pos].address_le; pos++) {
                 const char *curname = symbol_table[pos].symbol_name;
-                
+
                 /* Find a ':' in curname */
                 const char *colon = str_chr(curname, ':');
                 if (colon == NULL)
                         continue;
-                
+
                 if (str_length(curname) < namelen)
                         continue;
-                
+
                 if (str_lcmp(name, curname, namelen) == 0) {
                         *startpos = pos;
@@ -139 +139 @@
                 }
         }
-        
+
         return NULL;
 }
@@ -162 +162 @@
         size_t pos = 0;
         const char *hint;
-        
+
         while ((hint = symtab_search_one(name, &pos))) {
                 if (str_length(hint) == 0) {
@@ -170 +170 @@
                 pos++;
         }
-        
+
         if (found > 1)
                 return EOVERFLOW;
-        
+
         if (found < 1)
                 return ENOENT;
-        
+
         return EOK;
-        
+
 #else
         return ENOTSUP;
@@ -195 +195 @@
                 pos++;
         }
-        
+
 #else
         printf("No symbol information available.\n");
@@ -208 +208 @@
         size_t len = str_length(input);
         struct symtab_entry **entry = (struct symtab_entry**)ctx;
-        
+
         if (*entry == NULL)
                 *entry = symbol_table;
-        
+
         for (; (*entry)->address_le; (*entry)++) {
                 const char *curname = (*entry)->symbol_name;
-                
+
                 /* Find a ':' in curname */
                 const char *colon = str_chr(curname, ':');
                 if (colon == NULL)
                         continue;
-                
+
                 if (str_length(curname) < len)
                         continue;
-                
+
                 if (str_lcmp(input, curname, len) == 0) {
                         (*entry)++;
@@ -230 +230 @@
                 }
         }
-        
+
         return NULL;
-        
+
 #else
         return NULL;