Changeset a1732929 in mainline for uspace/app

Timestamp:

2018-01-15T17:04:34Z (8 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9ff99e8

Parents:

c1a966e

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-15 17:04:32)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-15 17:04:34)

Message:

usb: unified logging

Use logger instead of printf. Logger adds newlines automatically.

Location:

uspace/app

Files:

• usbinfo/hid.c (modified) (2 diffs)
• vuhid/hids/bootkbd.c (modified) (1 diff)
• vuhid/life.c (modified) (2 diffs)
• vuhid/main.c (modified) (1 diff)

uspace/app/usbinfo/hid.c

@@ -141 +141 @@
             raw_report, report_size, &actual_report_size);
         if (rc != EOK) {
-                usb_log_error("Failed to retrieve HID report descriptor: %s.\n",
+                usb_log_error("Failed to retrieve HID report descriptor: %s.",
                     str_error(rc));
                 free(raw_report);
@@ -150 +150 @@
         rc = usb_hid_parse_report_descriptor(&report, raw_report, report_size);
         if (rc != EOK) {
-                usb_log_error("Failed to part report descriptor: %s.\n",
+                usb_log_error("Failed to part report descriptor: %s.",
                     str_error(rc));
         }

uspace/app/vuhid/hids/bootkbd.c

@@ -110 +110 @@
 #define _GET_LED(index, signature) \
         (((leds) & (1 << index)) ? (signature) : '-')
-        usb_log_info("%s: LEDs = %c%c%c%c%c\n",
+        usb_log_info("%s: LEDs = %c%c%c%c%c",
             iface->name,
             _GET_LED(0, '0'), _GET_LED(1, 'A'), _GET_LED(2, 's'),

uspace/app/vuhid/life.c

@@ -45 +45 @@
         data->data_in_last_pos = (size_t) -1;
         async_usleep(1000 * 1000 * 5);
-        usb_log_debug("%s\n", data->msg_born);
+        usb_log_debug("%s", data->msg_born);
         while (data->data_in_pos < data->data_in_count) {
                 async_usleep(1000 * data->data_in_pos_change_delay);
@@ -51 +51 @@
                 data->data_in_pos++;
         }
-        usb_log_debug("%s\n", data->msg_die);
+        usb_log_debug("%s", data->msg_die);
 }
 

uspace/app/vuhid/main.c

@@ -227 +227 @@
 
         for (int i = 0; i < (int) hid_dev.descriptors->configuration->extra_count; i++) {
-                usb_log_debug("Found extra descriptor: %s.\n",
+                usb_log_debug("Found extra descriptor: %s.",
                     usb_debug_str_buffer(
                         hid_dev.descriptors->configuration->extra[i].data,