Changeset a000878c in mainline for kernel/generic/include

Timestamp:

2010-02-25T19:11:25Z (16 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

958de16

Parents:

a634485

Message:

make sure that all statically allocated strings are declared as "const char *"
and are treated as read-only

Location:

kernel/generic/include

Files:

• console/chardev.h (modified) (3 diffs)
• console/kconsole.h (modified) (1 diff)
• interrupt.h (modified) (1 diff)
• lib/elf.h (modified) (1 diff)
• mm/slab.h (modified) (2 diffs)
• panic.h (modified) (1 diff)
• proc/task.h (modified) (1 diff)
• proc/thread.h (modified) (2 diffs)
• stacktrace.h (modified) (1 diff)
• symtab.h (modified) (1 diff)
• synch/spinlock.h (modified) (2 diffs)

kernel/generic/include/console/chardev.h

@@ -53 +53 @@
 /** Character input device. */
 typedef struct indev {
-        char *name;
+        const char *name;
         waitq_t wq;
         
@@ -81 +81 @@
 /** Character output device. */
 typedef struct outdev {
-        char *name;
+        const char *name;
         
         /** Protects everything below. */
@@ -95 +95 @@
 } outdev_t;
 
-extern void indev_initialize(char *name, indev_t *indev,
+extern void indev_initialize(const char *name, indev_t *indev,
     indev_operations_t *op);
 extern void indev_push_character(indev_t *indev, wchar_t ch);
 extern wchar_t indev_pop_character(indev_t *indev);
 
-extern void outdev_initialize(char *name, outdev_t *outdev,
+extern void outdev_initialize(const char *name, outdev_t *outdev,
     outdev_operations_t *op);
 

kernel/generic/include/console/kconsole.h

@@ -94 +94 @@
 extern void kconsole_notify_init(void);
 extern bool kconsole_check_poll(void);
-extern void kconsole(char *prompt, char *msg, bool kcon);
+extern void kconsole(const char *prompt, const char *msg, bool kcon);
 extern void kconsole_thread(void *data);
 

kernel/generic/include/interrupt.h

@@ -46 +46 @@
 typedef void (* iroutine)(int n, istate_t *istate);
 
-extern void fault_if_from_uspace(istate_t *istate, char *fmt, ...);
+extern void fault_if_from_uspace(istate_t *istate, const char *fmt, ...);
 extern iroutine exc_register(int n, const char *name, iroutine f);
 extern void exc_dispatch(int n, istate_t *t);

kernel/generic/include/lib/elf.h

@@ -338 +338 @@
 #endif
 
-extern char *elf_error(unsigned int rc);
+extern const char *elf_error(unsigned int rc);
 
 /* Interpreter string used to recognize the program loader */

kernel/generic/include/mm/slab.h

@@ -86 +86 @@
 
 typedef struct {
-        char *name;
+        const char *name;
         
         link_t link;
@@ -123 +123 @@
 } slab_cache_t;
 
-extern slab_cache_t *slab_cache_create(char *, size_t, size_t,
+extern slab_cache_t *slab_cache_create(const char *, size_t, size_t,
     int (*)(void *, int), int (*)(void *), int);
 extern void slab_cache_destroy(slab_cache_t *);

kernel/generic/include/panic.h

@@ -60 +60 @@
 extern bool silent;
 
-extern void panic_printf(char *fmt, ...) __attribute__((noreturn));
+extern void panic_printf(const char *fmt, ...) __attribute__((noreturn));
 
 #endif

kernel/generic/include/proc/task.h

@@ -130 +130 @@
 extern void task_init(void);
 extern void task_done(void);
-extern task_t *task_create(as_t *as, char *name);
+extern task_t *task_create(as_t *as, const char *name);
 extern void task_destroy(task_t *t);
 extern task_t *task_find_by_id(task_id_t id);

kernel/generic/include/proc/thread.h

@@ -52 +52 @@
 #define THREAD_NAME_BUFLEN      20
 
-extern char *thread_states[];
+extern const char *thread_states[];
 
 /* Thread flags */
@@ -225 +225 @@
 
 extern void thread_init(void);
-extern thread_t *thread_create(void (*)(void *), void *, task_t *, int, char *,
-    bool);
+extern thread_t *thread_create(void (*)(void *), void *, task_t *, int,
+    const char *, bool);
 extern void thread_attach(thread_t *, task_t *);
 extern void thread_ready(thread_t *);

kernel/generic/include/stacktrace.h

@@ -46 +46 @@
         bool (* frame_pointer_prev)(uintptr_t, uintptr_t *);
         bool (* return_address_get)(uintptr_t, uintptr_t *);
-        bool (* symbol_resolve)(uintptr_t, char **, uintptr_t *);
+        bool (* symbol_resolve)(uintptr_t, const char **, uintptr_t *);
 } stack_trace_ops_t;
 

kernel/generic/include/symtab.h

@@ -45 +45 @@
 };
 
-extern int symtab_name_lookup(uintptr_t, char **, uintptr_t *);
-extern char *symtab_fmt_name_lookup(uintptr_t);
+extern int symtab_name_lookup(uintptr_t, const char **, uintptr_t *);
+extern const char *symtab_fmt_name_lookup(uintptr_t);
 extern int symtab_addr_lookup(const char *, uintptr_t *);
 extern void symtab_print_search(const char *);

kernel/generic/include/synch/spinlock.h

@@ -48 +48 @@
         
 #ifdef CONFIG_DEBUG_SPINLOCK
-        char *name;
+        const char *name;
 #endif
 } spinlock_t;
@@ -101 +101 @@
         SPINLOCK_STATIC_INITIALIZE_NAME(lock_name, #lock_name)
 
-extern void spinlock_initialize(spinlock_t *lock, char *name);
+extern void spinlock_initialize(spinlock_t *lock, const char *name);
 extern int spinlock_trylock(spinlock_t *lock);
 extern void spinlock_lock_debug(spinlock_t *lock);