Changeset 984a9ba in mainline for uspace/lib/nic

Timestamp:

2018-07-05T09:34:09Z (8 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

63d46341

Parents:

76f566d

Message:

do not expose the call capability handler from the async framework

Keep the call capability handler encapsulated within the async framework
and do not expose it explicitly via its API. Use the pointer to
ipc_call_t as the sole object identifying an IPC call in the code that
uses the async framework.

This plugs a major leak in the abstraction and also simplifies both the
async framework (slightly) and all IPC servers.

Location:

uspace/lib/nic

Files:

• include/nic_impl.h (modified) (1 diff)
• src/nic_impl.c (modified) (1 diff)

uspace/lib/nic/include/nic_impl.h

@@ -83 +83 @@
 extern errno_t nic_poll_now_impl(ddf_fun_t *);
 
-extern void nic_default_handler_impl(ddf_fun_t *dev_fun,
-    cap_call_handle_t chandle, ipc_call_t *call);
+extern void nic_default_handler_impl(ddf_fun_t *dev_fun, ipc_call_t *call);
 extern errno_t nic_open_impl(ddf_fun_t *fun);
 extern void nic_close_impl(ddf_fun_t *fun);

uspace/lib/nic/src/nic_impl.c

@@ -810 +810 @@
  * Logs a warning message and returns ENOTSUP to the caller.
  *
- * @param fun      The DDF function where the method should be called.
- * @param chandle  IPC call handle
- * @param call     IPC call data
- */
-void nic_default_handler_impl(ddf_fun_t *fun, cap_call_handle_t chandle,
-    ipc_call_t *call)
-{
-        async_answer_0(chandle, ENOTSUP);
+ * @param fun  The DDF function where the method should be called.
+ * @param call IPC call data
+ *
+ */
+void nic_default_handler_impl(ddf_fun_t *fun, ipc_call_t *call)
+{
+        async_answer_0(call, ENOTSUP);
 }