Changeset 95d45482 in mainline for kernel/generic/src

Timestamp:

2018-11-09T22:29:12Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

be6e37a

Parents:

436a0a5

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-11-08 23:08:28)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-11-09 22:29:12)

Message:

XXX to NOTE

Location:

kernel/generic/src

Files:

• cpu/cpu.c (modified) (1 diff)
• main/main.c (modified) (1 diff)
• proc/thread.c (modified) (1 diff)
• synch/spinlock.c (modified) (1 diff)

kernel/generic/src/cpu/cpu.c

@@ -71 +71 @@
                 memsetb(cpus, sizeof(cpu_t) * config.cpu_count, 0);
 
-                // XXX: All kernel stacks must be aligned to STACK_SIZE,
-                //      see get_stack_base().
+                // NOTE: All kernel stacks must be aligned to STACK_SIZE,
+                //       see get_stack_base().
                 size_t i;
                 for (i = 0; i < config.cpu_count; i++) {

kernel/generic/src/main/main.c

@@ -171 +171 @@
             ALIGN_UP((uintptr_t) kdata_end - config.base, PAGE_SIZE);
 
-        // XXX: All kernel stacks must be aligned to STACK_SIZE,
-        //      see get_stack_base().
+        // NOTE: All kernel stacks must be aligned to STACK_SIZE,
+        //       see get_stack_base().
 
         /* Place the stack after the kernel, init and ballocs. */

kernel/generic/src/proc/thread.c

@@ -190 +190 @@
         kmflags &= ~FRAME_HIGHMEM;
 
-        // XXX: All kernel stacks must be aligned to STACK_SIZE,
-        //      see get_stack_base().
+        // NOTE: All kernel stacks must be aligned to STACK_SIZE,
+        //       see get_stack_base().
 
         uintptr_t stack_phys =

kernel/generic/src/synch/spinlock.c

@@ -161 +161 @@
 bool spinlock_locked(spinlock_t *lock)
 {
-        // XXX: Atomic flag doesn't support simple atomic read (by design),
-        //      so instead we test_and_set and then clear if necessary.
-        //      This function is only used inside assert, so we don't need
-        //      any preemption_disable/enable here.
+        // NOTE: Atomic flag doesn't support simple atomic read (by design),
+        //       so instead we test_and_set and then clear if necessary.
+        //       This function is only used inside assert, so we don't need
+        //       any preemption_disable/enable here.
 
         bool ret = atomic_flag_test_and_set_explicit(&lock->flag, memory_order_relaxed);