Changeset 918e9910 in mainline for uspace/srv/net/tl

Timestamp:

2010-02-12T13:50:47Z (16 years ago)

Author:

Lukas Mejdrech <lukasmejdrech@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

827d73f

Parents:

4be390b

Message:

• zero IP checksum flip fix

Location:

uspace/srv/net/tl

Files:

• icmp/icmp.c (modified) (1 diff)
• tcp/tcp.c (modified) (1 diff)
• udp/udp.c (modified) (1 diff)

uspace/srv/net/tl/icmp/icmp.c

@@ -617 +617 @@
         // checksum
         if( header->checksum ){
-                while( ICMP_CHECKSUM( header, length )){
+                while( ICMP_CHECKSUM( header, length ) != IP_CHECKSUM_ZERO ){
                         // set the original message type on error notification
                         // type swap observed in Qemu

uspace/srv/net/tl/tcp/tcp.c

@@ -382 +382 @@
                 }
                 checksum = compute_checksum( checksum, socket_data->pseudo_header, socket_data->headerlen );
-                if( flip_checksum( compact_checksum( checksum ))){
+                if( flip_checksum( compact_checksum( checksum )) != IP_CHECKSUM_ZERO ){
                         printf( "checksum err %x -> %x\n", header->checksum, flip_checksum( compact_checksum( checksum )));
                         fibril_rwlock_write_unlock( socket_data->local_lock );

uspace/srv/net/tl/udp/udp.c

@@ -372 +372 @@
         // check checksum
         if( header->checksum ){
-                if( flip_checksum( compact_checksum( checksum ))){
+                if( flip_checksum( compact_checksum( checksum )) != IP_CHECKSUM_ZERO ){
                         if( tl_prepare_icmp_packet( udp_globals.net_phone, udp_globals.icmp_phone, packet, error ) == EOK ){
                                 // checksum error ICMP